From: "Seebs" <seebs@seebs.net>
To: "Richard Purdie" <richard.purdie@linuxfoundation.org>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH 2/4] pseudo: Ignore mismatched inodes from the db
Date: Mon, 28 Sep 2020 10:56:17 -0500 [thread overview]
Message-ID: <20200928105617.11183951@seebsdell> (raw)
In-Reply-To: <19cfd5621921a2cf1f19be76bf216c7ac42b2e4e.camel@linuxfoundation.org>
On Mon, 28 Sep 2020 15:51:53 +0100
"Richard Purdie" <richard.purdie@linuxfoundation.org> wrote:
> I understand. I have strong evidence that the current handling of such
> a case does the wrong thing though as copying the data from the
> original inode leads to pretty bad corruption in its own right.
Yes.
But if you had to choose between (1) discard the possibly-bad data,
and (2) abort(), 2 would be a MUCH better fix.
Don't treat this as a thing to be worked around. Treat it as a giant
red flag that *we no longer have a sound reason to think that the
database is valid*.
> In many ways I'd like to make these corner cases hard errors. In order
> to do that we need to ensure we're not hitting them though and to do
> that we need the next patch.
Yeah.
> Once we have the ability to ignore subtrees, we could just hard error
> for the potential corruption cases and force those issues to be
> addressed properly.
I think that is the right path.
-s
next prev parent reply other threads:[~2020-09-28 15:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 13:38 [PATCH 1/4] staging: Ensure cleaned dependencies are added Richard Purdie
2020-09-28 13:38 ` [PATCH 2/4] pseudo: Ignore mismatched inodes from the db Richard Purdie
2020-09-28 14:13 ` [OE-core] " Seebs
2020-09-28 14:51 ` Richard Purdie
2020-09-28 15:56 ` Seebs [this message]
2020-09-28 21:42 ` Richard Purdie
2020-09-29 17:05 ` Seebs
2020-09-28 13:38 ` [PATCH 3/4] pseudo: Add support for ignoring paths from the pseudo DB Richard Purdie
2020-09-28 13:38 ` [PATCH 4/4] base/bitbake.conf: Enable pseudo path filtering Richard Purdie
2020-09-28 15:15 ` [OE-core] [PATCH 1/4] staging: Ensure cleaned dependencies are added Christopher Larson
2020-09-28 17:03 ` Richard Purdie
2020-10-06 16:07 ` Chris Laplante
2020-10-06 16:49 ` Richard Purdie
2020-10-06 16:59 ` Chris Laplante
2020-10-07 10:29 ` Richard Purdie
2020-10-07 14:58 ` Chris Laplante
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200928105617.11183951@seebsdell \
--to=seebs@seebs.net \
--cc=openembedded-core@lists.openembedded.org \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox