Re: [OE-core] [meta-oe][PATCH v4 6/6] tunes/armv8: move to a new location

Khem Raj
2020-09-29T21:58:50Z

Lets not do it. For couple of reasons,

There are BSPs including these include files which are using same
branch across multiple yocto releases, this will break them
files under include/<ARCH> are common at arch level, this moved the
CPU implementation ( cortex* ) under it, seems odd and even more odd
when you consider arm32 tunes.

On Mon, Sep 28, 2020 at 6:06 AM Jon Mason <jdmason@kudzu.us> wrote:
>
> Move the ARMv8a tunes into a separate location (per generation). This
> should help reduce the number of tunes in the more generic location.
>
> Signed-off-by: Jon Mason <jon.mason@arm.com>
> ---
> meta/conf/machine/include/{ => arm/armv8-2a}/tune-cortexa55.inc | 0
> meta/conf/machine/include/{ => arm/armv8-2a}/tune-cortexa65.inc | 0
> .../machine/include/{ => arm/armv8-2a}/tune-cortexa65ae.inc | 0
> .../include/{ => arm/armv8-2a}/tune-cortexa75-cortexa55.inc | 0
> meta/conf/machine/include/{ => arm/armv8-2a}/tune-cortexa75.inc | 0
> .../include/{ => arm/armv8-2a}/tune-cortexa76-cortexa55.inc | 0
> meta/conf/machine/include/{ => arm/armv8-2a}/tune-cortexa76.inc | 0
> .../machine/include/{ => arm/armv8-2a}/tune-cortexa76ae.inc | 0
> meta/conf/machine/include/{ => arm/armv8-2a}/tune-cortexa77.inc | 0
> meta/conf/machine/include/{ => arm/armv8a}/tune-cortexa32.inc | 0
> meta/conf/machine/include/{ => arm/armv8a}/tune-cortexa34.inc | 0
> meta/conf/machine/include/{ => arm/armv8a}/tune-cortexa35.inc | 0
> meta/conf/machine/include/{ => arm/armv8a}/tune-cortexa53.inc | 0
> .../include/{ => arm/armv8a}/tune-cortexa57-cortexa53.inc | 0
> meta/conf/machine/include/{ => arm/armv8a}/tune-cortexa57.inc | 0
> .../include/{ => arm/armv8a}/tune-cortexa72-cortexa53.inc | 0
> meta/conf/machine/include/{ => arm/armv8a}/tune-cortexa72.inc | 0
> .../include/{ => arm/armv8a}/tune-cortexa73-cortexa35.inc | 0
> .../include/{ => arm/armv8a}/tune-cortexa73-cortexa53.inc | 0
> meta/conf/machine/include/{ => arm/armv8a}/tune-cortexa73.inc | 0
> meta/conf/machine/qemuarm64.conf | 2 +-
> 21 files changed, 1 insertion(+), 1 deletion(-)
> rename meta/conf/machine/include/{ => arm/armv8-2a}/tune-cortexa55.inc (100%)
> rename meta/conf/machine/include/{ => arm/armv8-2a}/tune-cortexa65.inc (100%)
> rename meta/conf/machine/include/{ => arm/armv8-2a}/tune-cortexa65ae.inc (100%)
> rename meta/conf/machine/include/{ => arm/armv8-2a}/tune-cortexa75-cortexa55.inc (100%)
> rename meta/conf/machine/include/{ => arm/armv8-2a}/tune-cortexa75.inc (100%)
> rename meta/conf/machine/include/{ => arm/armv8-2a}/tune-cortexa76-cortexa55.inc (100%)
> rename meta/conf/machine/include/{ => arm/armv8-2a}/tune-cortexa76.inc (100%)
> rename meta/conf/machine/include/{ => arm/armv8-2a}/tune-cortexa76ae.inc (100%)
> rename meta/conf/machine/include/{ => arm/armv8-2a}/tune-cortexa77.inc (100%)
> rename meta/conf/machine/include/{ => arm/armv8a}/tune-cortexa32.inc (100%)
> rename meta/conf/machine/include/{ => arm/armv8a}/tune-cortexa34.inc (100%)
> rename meta/conf/machine/include/{ => arm/armv8a}/tune-cortexa35.inc (100%)
> rename meta/conf/machine/include/{ => arm/armv8a}/tune-cortexa53.inc (100%)
> rename meta/conf/machine/include/{ => arm/armv8a}/tune-cortexa57-cortexa53.inc (100%)
> rename meta/conf/machine/include/{ => arm/armv8a}/tune-cortexa57.inc (100%)
> rename meta/conf/machine/include/{ => arm/armv8a}/tune-cortexa72-cortexa53.inc (100%)
> rename meta/conf/machine/include/{ => arm/armv8a}/tune-cortexa72.inc (100%)
> rename meta/conf/machine/include/{ => arm/armv8a}/tune-cortexa73-cortexa35.inc (100%)
> rename meta/conf/machine/include/{ => arm/armv8a}/tune-cortexa73-cortexa53.inc (100%)
> rename meta/conf/machine/include/{ => arm/armv8a}/tune-cortexa73.inc (100%)
>
> diff --git a/meta/conf/machine/include/tune-cortexa55.inc b/meta/conf/machine/include/arm/armv8-2a/tune-cortexa55.inc
> similarity index 100%
> rename from meta/conf/machine/include/tune-cortexa55.inc
> rename to meta/conf/machine/include/arm/armv8-2a/tune-cortexa55.inc
> diff --git a/meta/conf/machine/include/tune-cortexa65.inc b/meta/conf/machine/include/arm/armv8-2a/tune-cortexa65.inc
> similarity index 100%
> rename from meta/conf/machine/include/tune-cortexa65.inc
> rename to meta/conf/machine/include/arm/armv8-2a/tune-cortexa65.inc
> diff --git a/meta/conf/machine/include/tune-cortexa65ae.inc b/meta/conf/machine/include/arm/armv8-2a/tune-cortexa65ae.inc
> similarity index 100%
> rename from meta/conf/machine/include/tune-cortexa65ae.inc
> rename to meta/conf/machine/include/arm/armv8-2a/tune-cortexa65ae.inc
> diff --git a/meta/conf/machine/include/tune-cortexa75-cortexa55.inc b/meta/conf/machine/include/arm/armv8-2a/tune-cortexa75-cortexa55.inc
> similarity index 100%
> rename from meta/conf/machine/include/tune-cortexa75-cortexa55.inc
> rename to meta/conf/machine/include/arm/armv8-2a/tune-cortexa75-cortexa55.inc
> diff --git a/meta/conf/machine/include/tune-cortexa75.inc b/meta/conf/machine/include/arm/armv8-2a/tune-cortexa75.inc
> similarity index 100%
> rename from meta/conf/machine/include/tune-cortexa75.inc
> rename to meta/conf/machine/include/arm/armv8-2a/tune-cortexa75.inc
> diff --git a/meta/conf/machine/include/tune-cortexa76-cortexa55.inc b/meta/conf/machine/include/arm/armv8-2a/tune-cortexa76-cortexa55.inc
> similarity index 100%
> rename from meta/conf/machine/include/tune-cortexa76-cortexa55.inc
> rename to meta/conf/machine/include/arm/armv8-2a/tune-cortexa76-cortexa55.inc
> diff --git a/meta/conf/machine/include/tune-cortexa76.inc b/meta/conf/machine/include/arm/armv8-2a/tune-cortexa76.inc
> similarity index 100%
> rename from meta/conf/machine/include/tune-cortexa76.inc
> rename to meta/conf/machine/include/arm/armv8-2a/tune-cortexa76.inc
> diff --git a/meta/conf/machine/include/tune-cortexa76ae.inc b/meta/conf/machine/include/arm/armv8-2a/tune-cortexa76ae.inc
> similarity index 100%
> rename from meta/conf/machine/include/tune-cortexa76ae.inc
> rename to meta/conf/machine/include/arm/armv8-2a/tune-cortexa76ae.inc
> diff --git a/meta/conf/machine/include/tune-cortexa77.inc b/meta/conf/machine/include/arm/armv8-2a/tune-cortexa77.inc
> similarity index 100%
> rename from meta/conf/machine/include/tune-cortexa77.inc
> rename to meta/conf/machine/include/arm/armv8-2a/tune-cortexa77.inc
> diff --git a/meta/conf/machine/include/tune-cortexa32.inc b/meta/conf/machine/include/arm/armv8a/tune-cortexa32.inc
> similarity index 100%
> rename from meta/conf/machine/include/tune-cortexa32.inc
> rename to meta/conf/machine/include/arm/armv8a/tune-cortexa32.inc
> diff --git a/meta/conf/machine/include/tune-cortexa34.inc b/meta/conf/machine/include/arm/armv8a/tune-cortexa34.inc
> similarity index 100%
> rename from meta/conf/machine/include/tune-cortexa34.inc
> rename to meta/conf/machine/include/arm/armv8a/tune-cortexa34.inc
> diff --git a/meta/conf/machine/include/tune-cortexa35.inc b/meta/conf/machine/include/arm/armv8a/tune-cortexa35.inc
> similarity index 100%
> rename from meta/conf/machine/include/tune-cortexa35.inc
> rename to meta/conf/machine/include/arm/armv8a/tune-cortexa35.inc
> diff --git a/meta/conf/machine/include/tune-cortexa53.inc b/meta/conf/machine/include/arm/armv8a/tune-cortexa53.inc
> similarity index 100%
> rename from meta/conf/machine/include/tune-cortexa53.inc
> rename to meta/conf/machine/include/arm/armv8a/tune-cortexa53.inc
> diff --git a/meta/conf/machine/include/tune-cortexa57-cortexa53.inc b/meta/conf/machine/include/arm/armv8a/tune-cortexa57-cortexa53.inc
> similarity index 100%
> rename from meta/conf/machine/include/tune-cortexa57-cortexa53.inc
> rename to meta/conf/machine/include/arm/armv8a/tune-cortexa57-cortexa53.inc
> diff --git a/meta/conf/machine/include/tune-cortexa57.inc b/meta/conf/machine/include/arm/armv8a/tune-cortexa57.inc
> similarity index 100%
> rename from meta/conf/machine/include/tune-cortexa57.inc
> rename to meta/conf/machine/include/arm/armv8a/tune-cortexa57.inc
> diff --git a/meta/conf/machine/include/tune-cortexa72-cortexa53.inc b/meta/conf/machine/include/arm/armv8a/tune-cortexa72-cortexa53.inc
> similarity index 100%
> rename from meta/conf/machine/include/tune-cortexa72-cortexa53.inc
> rename to meta/conf/machine/include/arm/armv8a/tune-cortexa72-cortexa53.inc
> diff --git a/meta/conf/machine/include/tune-cortexa72.inc b/meta/conf/machine/include/arm/armv8a/tune-cortexa72.inc
> similarity index 100%
> rename from meta/conf/machine/include/tune-cortexa72.inc
> rename to meta/conf/machine/include/arm/armv8a/tune-cortexa72.inc
> diff --git a/meta/conf/machine/include/tune-cortexa73-cortexa35.inc b/meta/conf/machine/include/arm/armv8a/tune-cortexa73-cortexa35.inc
> similarity index 100%
> rename from meta/conf/machine/include/tune-cortexa73-cortexa35.inc
> rename to meta/conf/machine/include/arm/armv8a/tune-cortexa73-cortexa35.inc
> diff --git a/meta/conf/machine/include/tune-cortexa73-cortexa53.inc b/meta/conf/machine/include/arm/armv8a/tune-cortexa73-cortexa53.inc
> similarity index 100%
> rename from meta/conf/machine/include/tune-cortexa73-cortexa53.inc
> rename to meta/conf/machine/include/arm/armv8a/tune-cortexa73-cortexa53.inc
> diff --git a/meta/conf/machine/include/tune-cortexa73.inc b/meta/conf/machine/include/arm/armv8a/tune-cortexa73.inc
> similarity index 100%
> rename from meta/conf/machine/include/tune-cortexa73.inc
> rename to meta/conf/machine/include/arm/armv8a/tune-cortexa73.inc
> diff --git a/meta/conf/machine/qemuarm64.conf b/meta/conf/machine/qemuarm64.conf
> index 2f61eb0aed5f..c4096d0eeea4 100644
> --- a/meta/conf/machine/qemuarm64.conf
> +++ b/meta/conf/machine/qemuarm64.conf
> @@ -2,7 +2,7 @@
> #@NAME: QEMU ARMv8 machine
> #@DESCRIPTION: Machine configuration for running an ARMv8 system on QEMU
>
> -require conf/machine/include/tune-cortexa57.inc
> +require conf/machine/include/arm/armv8a/tune-cortexa57.inc
> require conf/machine/include/qemu.inc
>
> KERNEL_IMAGETYPE = "Image"
> --
> 2.20.1
>
>
>
>