Re: [OE-core] [PATCH] Revert "kernel.bbclass: make dependency on lzop-native conditional"

["Marco Felsch" <m.felsch@pengutronix.de>]

On 20-10-07 12:28, Richard Purdie wrote:
> On Mon, 2020-10-05 at 16:18 +0200, Marco Felsch wrote:
> > This reverts commit 1217ddf070261c5fe523729b2a833bd38f1e4ccd.
> > 
> > This commit breaks compiling if no initramfs is used because the kernel
> > image can be compressed too using lzo.
> > 
> > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> > ---
> >  meta/classes/kernel.bbclass | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> > index 78def5bbc1..06150e8072 100644
> > --- a/meta/classes/kernel.bbclass
> > +++ b/meta/classes/kernel.bbclass
> > @@ -4,8 +4,7 @@ KERNEL_PACKAGE_NAME ??= "kernel"
> >  KERNEL_DEPLOYSUBDIR ??= "${@ "" if (d.getVar("KERNEL_PACKAGE_NAME") == "kernel") else d.getVar("KERNEL_PACKAGE_NAME") }"
> >  
> >  PROVIDES += "${@ "virtual/kernel" if (d.getVar("KERNEL_PACKAGE_NAME") == "kernel") else "" }"
> > -DEPENDS += "virtual/${TARGET_PREFIX}binutils virtual/${TARGET_PREFIX}gcc kmod-native bc-native bison-native"
> > -DEPENDS += "${@bb.utils.contains("INITRAMFS_FSTYPES", "cpio.lzo", "lzop-native", "", d)}"
> > +DEPENDS += "virtual/${TARGET_PREFIX}binutils virtual/${TARGET_PREFIX}gcc kmod-native bc-native lzop-native bison-native"
> >  DEPENDS += "${@bb.utils.contains("INITRAMFS_FSTYPES", "cpio.lz4", "lz4-native", "", d)}"
> >  PACKAGE_WRITE_DEPS += "depmodwrapper-cross"
> 
> I've been giving this more thought, we can't simply add every possible
> DEPENDS in kernel.bbclass.
> 
> In this case if a recipe is enabling lzo compression on the kernel,
> perhaps it should just add DEPENDS += "lzop-native" itself?

You're absolutely right and I would have no doubts going this way if we
won't have this dependency since 2016. I think this will break a lot of
builds. We can go this if that doesn't matter, but I would drop the
dynamically added DEPENDS which would be added in case of
INITRAMFS_FSTYPES. So the BSP needs to specify the correct DEPS all the
time.

Regards,
  Marco