From: "Randy Witt" <randy.e.witt@linux.intel.com>
To: openembedded-core@lists.openembedded.org
Cc: Randy Witt <randy.e.witt@intel.com>,
Randy Witt <randy.e.witt@linux.intel.com>
Subject: [PATCH 3/4] numactl: Skip the ptests when numa is not supported
Date: Mon, 19 Oct 2020 14:42:13 -0700 [thread overview]
Message-ID: <20201019214214.2528690-4-randy.e.witt@linux.intel.com> (raw)
In-Reply-To: <20201019214214.2528690-1-randy.e.witt@linux.intel.com>
From: Randy Witt <randy.e.witt@intel.com>
When numa is not supported, there is no reason to run the ptests since
they will fail. While the best scenario would be for the upstream tests
to skip themselves when numa is not supported, for now skip them in
run-ptest.
Signed-off-by: Randy Witt <randy.e.witt@linux.intel.com>
---
.../recipes-support/numactl/numactl/run-ptest | 24 +++++++++++++++----
1 file changed, 19 insertions(+), 5 deletions(-)
diff --git a/meta/recipes-support/numactl/numactl/run-ptest b/meta/recipes-support/numactl/numactl/run-ptest
index 215f7c25b99..bf269da7559 100755
--- a/meta/recipes-support/numactl/numactl/run-ptest
+++ b/meta/recipes-support/numactl/numactl/run-ptest
@@ -1,9 +1,23 @@
#!/bin/sh
-make regress1
-make regress2
-if numademo -t -e 10M; then
- echo "PASS: numademo"
+
+# If there is numa support, run the tests. Otherwise skip all the tests.
+# Ideally the skipping would happen by the upstream tests.
+if ! numactl -s | grep -q "No NUMA support available on this system."; then
+ make regress1
+ make regress2
+ if numademo -t -e 10M; then
+ echo "PASS: numademo"
+ else
+ echo "FAIL: numademo"
+ fi
else
- echo "FAIL: numademo"
+ echo "SKIP: ./../test/bind_range"
+ echo "SKIP: ./../test/checkaffinity"
+ echo "SKIP: ./../test/checktopology"
+ echo "SKIP: ./../test/distance"
+ echo "SKIP: ./../test/nodemap"
+ echo "SKIP: ./../test/tbitmap"
+ echo "SKIP: numactl_regress"
+ echo "SKIP: numademo"
fi
--
2.26.2
next prev parent reply other threads:[~2020-10-19 21:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 21:42 [PATCH 0/4] Upgrade rt-tests to v1.8 Randy Witt
2020-10-19 21:42 ` [PATCH 1/4] numactl: Add the recipe for numactl Randy Witt
2020-10-19 21:42 ` [PATCH 2/4] numactl: Remove COMPATIBLE_HOST restrictions Randy Witt
2020-10-19 21:42 ` Randy Witt [this message]
2020-10-19 21:42 ` [PATCH 4/4] rt-tests: Update recipes to use 1.8 Randy Witt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201019214214.2528690-4-randy.e.witt@linux.intel.com \
--to=randy.e.witt@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=randy.e.witt@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox