Re: [OE-core] [PATCH 1/1] systemd.bbclass: check whether systemctl works in post scripts

["Andreas Oberritter" <obi@opendreambox.org>]

Hello Kai,

On Thu, 29 Oct 2020 17:26:50 +0800
"kai" <kai.kang@windriver.com> wrote:

> From: Kai Kang <kai.kang@windriver.com>
> 
> When use a core image tarball as a docker image with 'docker import', it
> fails to install/remove package which calls systemctl in post scripts.
> Because it fais to run systemctl in a container:
> 
> bash-5.0# systemctl
> System has not been booted with systemd as init system (PID 1). Can't operate.
> Failed to connect to bus: Host is down
> 
> Replace 'type systemctl' with 'systemctl list-machines' in package post
> scripts to check whether systemctl work rather than existence.
> 
> Signed-off-by: Kai Kang <kai.kang@windriver.com>
> ---
>  meta/classes/systemd.bbclass | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/classes/systemd.bbclass b/meta/classes/systemd.bbclass
> index 9e8a82c9f1..9938425e2d 100644
> --- a/meta/classes/systemd.bbclass
> +++ b/meta/classes/systemd.bbclass
> @@ -23,7 +23,7 @@ python __anonymous() {
>  }
>  
>  systemd_postinst() {
> -if type systemctl >/dev/null 2>/dev/null; then
> +if systemctl list-machines >/dev/null 2>/dev/null; then
>  	OPTS=""
>  
>  	if [ -n "$D" ]; then

Shouldn't this already have been run during image construction?

Doesn't this break our systemctl emulation (meta/recipes-core/systemd/systemd-systemctl/systemctl)?

> @@ -48,7 +48,7 @@ fi
>  }
>  
>  systemd_prerm() {
> -if type systemctl >/dev/null 2>/dev/null; then
> +if systemctl list-machines >/dev/null 2>/dev/null; then
>  	if [ -z "$D" ]; then
>  		systemctl stop ${SYSTEMD_SERVICE_ESCAPED}
>  

You're running the prerm hook inside a docker container?

Wouldn't it be more appropriate to remove the systemd DISTRO_FEATURE for a use-case like this?

Best regards,
Andreas