Re: [OE-core] [PATCH v5 05/22] gstreamer1.0-plugins-good: upgrade to version 1.18.0

Jose Quaresma
2020-10-30T18:35:05Z

It's probably better to wait and send two little fixup after the
series is applied on the master.

Thanks for the help

Alexander Kanavin <alex.kanavin@gmail.com> escreveu no dia sexta,
30/10/2020 à(s) 18:28:
>
> Since the patches are already in master-next, and will likely not cause any problems, maybe it's easier to create small followup patches, and send them once the main set merges, instead of sending a massive full set again.
>
> Alex
>
> On Fri, 30 Oct 2020 at 19:23, Jose Quaresma <quaresma.jose@gmail.com> wrote:
>>
>> Hi Richard,
>>
>> I see your fix:
>>
>> -PACKAGECONFIG[asm] = "-Dasm=enabled,-Dasm=disabled,nasm"
>> +PACKAGECONFIG[asm] = "-Dasm=enabled,-Dasm=disabled,nasm nasm-native"
>>
>> and only nasm-native is needed,
>> because nasm is not needed on target and it's only needed at build time.
>>
>> I can fix it and send v6 series and I have another fix for this series
>> that remove
>> 0004-capfix.patc in gstreamer1.0: upgrade to version 1.18.0
>> What do you think?
>>
>> I hope this is the last version and I will be more careful next time I
>> submit a big patch series.
>>
>> Jose Quaresma via lists.openembedded.org
>> <quaresma.jose=gmail.com@lists.openembedded.org> escreveu no dia
>> sexta, 30/10/2020 à(s) 17:57:
>> >
>> > Richard Purdie <richard.purdie@linuxfoundation.org> escreveu no dia
>> > sexta, 30/10/2020 à(s) 17:45:
>> > >
>> > > On Fri, 2020-10-30 at 16:47 +0000, Jose Quaresma wrote:
>> > > > nasm is present on sysroot
>> > > >
>> > > > The build log
>> > > > https://errors.yoctoproject.org/Errors/Details/510826/
>> > > >
>> > > > Countain:
>> > > >
>> > > > NOTE: Direct dependencies are:
>> > > > '/home/pokybuild/yocto-worker/qemux86-64-ltp/build/meta/recipes-
>> > > > devtools/nasm/nasm_2.15.05.bb:do_populate_sysroot'
>> > > >
>> > > > NOTE: Skipping as already exists in sysroot:
>> > > > 'nasm'
>> > > >
>> > > > I don't have a build it on qemux86-64 and only build on arm
>> > > > and on arm it is builded without nasm because -Dasm=disabled
>> > > > Otherwise I think everything is correct with this patch
>> > >
>> > > I was able to reproduce by building qemux86-64, it readily fails. The
>> > > issue is that it needs nasm-native. If I add nasm-native to the
>> > > dependency line it seems to build fine.
>> >
>> > Big mistake and I don't see it, of course it was the native nasm that
>> > is needed to build.
>> > Sorry for that and thanks for looking into this.
>> >
>> > >
>> > > I'll add that and retest on the autobuilder. If that works I'll squash
>> > > it in.
>> > >
>> > > Cheers,
>> > >
>> > > Richard
>> > >
>> >
>> >
>> > --
>> > best regards,
>> > José Quaresma
>> >
>> >
>> >
>>
>>
>> --
>> best regards,
>> José Quaresma
>>
>>
>>

--
best regards,
José Quaresma