Re: [OE-core] [PATCH v5 05/22] gstreamer1.0-plugins-good: upgrade to version 1.18.0

Richard Purdie
2020-10-31T00:49:14Z

On Fri, 2020-10-30 at 19:23 +0000, Richard Purdie wrote:
> On Fri, 2020-10-30 at 18:23 +0000, Jose Quaresma wrote:
> > Hi Richard,
> >
> > I see your fix:
> >
> > -PACKAGECONFIG[asm] = "-Dasm=enabled,-Dasm=disabled,nasm"
> > +PACKAGECONFIG[asm] = "-Dasm=enabled,-Dasm=disabled,nasm nasm-
> > native"
> >
> > and only nasm-native is needed,
> > because nasm is not needed on target and it's only needed at build
> > time.
>
> I was thinking about that after I sent the email. I've tweaked it
> again
> in master-next and squashed it into the series since it was easiest
> to
> do that.
>
> > I can fix it and send v6 series and I have another fix for this
> > series that remove 0004-capfix.patc in gstreamer1.0: upgrade to
> > version 1.18.0 What do you think?
>
> We can make this one a follow up to the series.
>
> > I hope this is the last version and I will be more careful next
> > time
> > I submit a big patch series.
>
> No problem, thanks for doing the work in creating it! The end result
> should be good and its nice to stay close to upstream releases. I'm
> think we're just about there now.

Just to follow up, you renamed gst->validate -> gst-devtool but didn't
update the maintainers entry. I've added that. We also found that a
dependency you added, json-glib had reproducibility failures[1] as it
wasn't being tested previously. I spotted a previous similar issue we
fixed like this and Alex was kind enough to send a patch.

[1] e.g. https://autobuilder.yocto.io/pub/repro-fail/oe-reproducible-20201030-ld3_vz4a/packages/diff-html/

I'm running another test build, hopefully this one will be better!

Cheers,

Richard