Re: [OE-core] [PATCH v5 01/22] gstreamer1.0: Fix reproducibility issue around libcap

Jose Quaresma
2020-10-29T16:58:32Z

I will need to rebuild and check if when setcap is enabled it will
pick setcap from host on from libcap-
native.

Richard Purdie <richard.purdie@linuxfoundation.org> escreveu no dia
quinta, 29/10/2020 à(s) 16:43:
>
> On Thu, 2020-10-29 at 16:13 +0000, Jose Quaresma wrote:
> > It looks for setcap in /usr/sbin and /sbin but needs libcap as wheel.
> > when we have libcaps on DEPENDS as with version 1.16 and the host
> > system has setcap binary, it introduces a dependency on the host
> > system.
> > The patch fixes this situation.
> >
> > But libcap is only needed if we need to use the setcap
> > So remove libcap from DEPENDS will fail to use
> > 'ptp-helper-permissions=capabilities' even if setcap is found on the
> > host.
> >
> > In my opinion this a better description can be used in this
> > PACKAGECONFIG, something like this:
> >
> > -PACKAGECONFIG[setcap] = ",,libcap libcap-native"
> > +PACKAGECONFIG[capabilities] =
> > "-Dptp-helper-permissions=capabilities,,libcap libcap-native"
>
> So you're saying that as long as setcap isn't in DEPENDS, we're ok?
> That means your patchset as it stands should be ok?
>
> If the user enables capabilities, it won't find setcap from libcap-
> native though will it? That is a potential problem even if its not the
> default?
>
> Cheers,
>
> Richard
>

--
best regards,
José Quaresma