Re: [PATCH v3] dbus: split -common and -tools out of main package

Luca Bocassi
2020-11-13T14:50:47Z

On Fri, 2020-11-13 at 14:34 +0000, Richard Purdie wrote:
> On Fri, 2020-11-13 at 10:47 +0000, luca.boccassi@gmail.com wrote:
> > From: Luca Boccassi <luca.boccassi@microsoft.com>
> >
> > Certain config files and units are shared between dbus-daemon and
> > dbus-broker (available in meta-openembedded), so split them out to
> > allow installing dbus-broker without pulling in dbus-daemon and its
> > dependencies.
> > Stand-alone command line tools can also be used regardless of whether
> > the buses are provided by dbus-daemon or dbus-broker, so split them
> > out into dbus-tools.
> > Finally, move the XML schema files out of the main package and into
> > the development package.
> >
> > All these changes follow the same pattern used by Fedora, which was
> > one of the first distro to switch to dbus-broker by default:
> >
> > https://src.fedoraproject.org/rpms/dbus/blob/master/f/dbus.spec
> >
> > Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
> > ---
> > v2: fix FILES_ regex to correctly include all units but the sockets
> > in the main package
> > v3: do not use ${PN} in RDEPENDS, as bitbake expansion is broken and
> > generates wrong values (eg: dbus-native-common-native)
>
> Without testing I can tell this will break multilib.
>
> RDEPENDS and native are a little confusing and tricky, basically due to
> legacy. This is why you'll see RDEPENDS_${PN}_class-native = "" and
> that is probably what is needed here.
>
> Cheers,
>
> Richard

Ok, sent a v4, even though I really do not follow - there's already
this in the recipe:

RDEPENDS_dbus_class-native = ""

Also won't that mean that for native builds there's no dependency, thus
breaking the dbus package (the required conf is no longer installed)?

--
Kind regards,
Luca Boccassi