From: "William Hauser" <william.hauser@meraki.net>
To: openembedded-core@lists.openembedded.org
Cc: William Hauser <whauser@meraki.com>,
William Hauser <william.hauser@meraki.com>
Subject: [PATCH] package.bbclass: fix image_debugfs symlinks
Date: Wed, 4 Nov 2020 14:47:43 -0800 [thread overview]
Message-ID: <20201104224743.74488-1-whauser@meraki.com> (raw)
Allow symlinks to be made in the debugfs by removing an incorrect check that
would always prevent symlinks from being transferred over.
The comment in this code indicates that the code is meant to ensure symlinks
are only copied to the debugfs if their target has already been copied, but
instead checks for the existence of the symlink that has yet to be created.
As a result this check always fails.
This check is safe to get rid of since we will only attempt to copy a
symlink to the debugfs if it's original target exists and is an ELF. It
is, however, still possible for a dead symlink to end up in the debugfs
if its original target was stripped.
Signed-off-by: William Hauser <william.hauser@meraki.com>
---
meta/classes/package.bbclass | 8 --------
1 file changed, 8 deletions(-)
diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
index e6236c0bb2..47f3df2e13 100644
--- a/meta/classes/package.bbclass
+++ b/meta/classes/package.bbclass
@@ -1258,14 +1258,6 @@ python split_and_strip_files () {
src = file[len(dvar):]
dest = debuglibdir + os.path.dirname(src) + debugdir + "/" + os.path.basename(src) + debugappend
fpath = dvar + dest
- # Skip it if the target doesn't exist
- try:
- s = os.stat(fpath)
- except OSError as e:
- (err, strerror) = e.args
- if err != errno.ENOENT:
- raise
- continue
ltarget = symlinks[file]
lpath = os.path.dirname(ltarget)
--
2.15.1
next reply other threads:[~2020-11-04 22:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 22:47 William Hauser [this message]
2020-11-08 9:29 ` [OE-core] [PATCH] package.bbclass: fix image_debugfs symlinks Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201104224743.74488-1-whauser@meraki.com \
--to=william.hauser@meraki.net \
--cc=openembedded-core@lists.openembedded.org \
--cc=whauser@meraki.com \
--cc=william.hauser@meraki.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox