Re: [OE-core] [PATCH 1/1] oe-buildenv-internal: Support extra settings

["Andreas Oberritter" <obi@opendreambox.org>]

Dear Robert,

On Thu, 12 Nov 2020 19:25:49 +0800
"Robert Yang" <liezhi.yang@windriver.com> wrote:

> This can make it possible to do extra settings such as PATH for other layers,
> for exampole, other layers may also have scripts directories as oe-core, we
> have to run them with path since they are not in PATH, for example, there is a
> tool meta-browser/scripts/firefox-gen-l10n-recipes, we have to use
> /path/to/meta-browser/scripts to run it. Make oe-buildenv-internal check and
> enable $OEROOT/extrasettings, and set a line like the following can fix the
> problem:
> 
> PATH=/relative/to/$OEROOT/meta-browser/scripts:$PATH
> 
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> ---
>  scripts/oe-buildenv-internal | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/scripts/oe-buildenv-internal b/scripts/oe-buildenv-internal
> index ba0a9b44d6..bf84003d72 100755
> --- a/scripts/oe-buildenv-internal
> +++ b/scripts/oe-buildenv-internal
> @@ -98,6 +98,10 @@ for newpath in "$BITBAKEDIR/bin" "$OEROOT/scripts"; do
>  done
>  unset BITBAKEDIR newpath
>  
> +if [ -e $OEROOT/extrasettings ]; then
> +. $OEROOT/extrasettings
> +fi

I think this filename isn't very descriptive, and people finding this file might wonder what it is about.

How about sourcing all files (maybe with a given suffix like .sh) in $OEROOT/scripts/oe-buildenv-internal.d/ in lexical order?

Regards,
Andreas