Re: [OE-core] [PATCH] mesa.inc: add dispmanx support

Trevor Woerner
2020-12-03T21:54:31Z

[-- Attachment #1: Type: text/plain, Size: 937 bytes --]

On Thu, Dec 3, 2020 at 2:01 PM Khem Raj <raj.khem@gmail.com> wrote:

> On Thu, Dec 3, 2020 at 5:35 AM Trevor Woerner <twoerner@gmail.com> wrote:
> > -ANY_OF_DISTRO_FEATURES_class-target = "opengl vulkan"
> > +ANY_OF_DISTRO_FEATURES_class-target = "opengl vulkan dispmanx"
> >
>
> dispmanx is only supported by userland graphics and we do have a
> machine feature knob for that
> this addition seems not common enough to warrant inclusion in OE-Core.
> I would suggest to keep it
> in meta-raspberrypi via a bbappend using the machine feature check

I agree with you 100%, and I resisted the idea of a new DISTRO_FEATURE too.
However… Adding "dispmanx" as a new DISTRO_FEATURE here was done almost
entirely in order to support the changes I made to
meta-openembedded's meta-oe/recipes-benchmarks/glmark2. I don't think that
the kind of changes needed over there are possible to do in a bbappend in a
BSP layer (?).

[-- Attachment #2: Type: text/html, Size: 1331 bytes --]