Re: [OE-core] [PATCH] mesa.inc: add dispmanx support

Trevor Woerner
2020-12-03T22:35:35Z

[-- Attachment #1: Type: text/plain, Size: 3382 bytes --]

On Thu, Dec 3, 2020 at 5:25 PM Phil Blundell <pb@pbcl.net> wrote:

> If we're talking about OpenGLES applications, wouldn't you already have
> opengl in DISTRO_FEATURES?
>

Not necessarily.

Adding opengl to DISTRO_FEATURES really means "enable a bunch of
PACKAGECONFIGs all over the place because I need x11 and mesa with all the
bells and whistles". These things are not necessary to build and run apps
based on dispmanx. With this patch and my patch to meta-openembedded I'm
able to build "core-image-minimal" with no x11/wayland, no window managers,
with "userland" and with "glmark2". Here is my package list:

1 base-files_3.0.14-r89_raspberrypi3.ipk
2 base-passwd_3.5.29-r0_cortexa7t2hf-neon-vfpv4.ipk
3 bash_5.0-r0_cortexa7t2hf-neon-vfpv4.ipk
4 busybox_1.32.0-r0_cortexa7t2hf-neon-vfpv4.ipk
5 busybox-syslog_1.32.0-r0_cortexa7t2hf-neon-vfpv4.ipk
6 busybox-udhcpc_1.32.0-r0_cortexa7t2hf-neon-vfpv4.ipk
7 eudev_3.2.9-r0_cortexa7t2hf-neon-vfpv4.ipk
8 glmark2_2020.11+0+784aca755a-r0_cortexa7t2hf-neon-vfpv4.ipk
9 init-ifupdown_1.0-r7_raspberrypi3.ipk
10 initscripts-functions_1.0-r155_cortexa7t2hf-neon-vfpv4.ipk
11 initscripts_1.0-r155_cortexa7t2hf-neon-vfpv4.ipk
12 init-system-helpers-service_1.58-r0_cortexa7t2hf-neon-vfpv4.ipk
13 kbd_2.3.0-r0_cortexa7t2hf-neon-vfpv4.ipk
14 kernel-5.4.79-v7_1:5.4.79+git0+5d52d9eea9_9797f1a493-r0_raspberrypi3.ipk
15
kernel-module-i2c-bcm2708-5.4.79-v7_1:5.4.79+git0+5d52d9eea9_9797f1a493-r0_raspberrypi3.ipk
16
kernel-module-i2c-dev-5.4.79-v7_1:5.4.79+git0+5d52d9eea9_9797f1a493-r0_raspberrypi3.ipk
17 keymaps_1.0-r31_raspberrypi3.ipk
18 ldconfig_2.32-r0_cortexa7t2hf-neon-vfpv4.ipk
19 libblkid1_2.36-r0_cortexa7t2hf-neon-vfpv4.ipk
20 libc6_2.32-r0_cortexa7t2hf-neon-vfpv4.ipk
21 libgcc1_10.2.0-r0_cortexa7t2hf-neon-vfpv4.ipk
22 libjpeg62_1:2.0.6-r0_cortexa7t2hf-neon-vfpv4.ipk
23 libkmod2_27-r0_cortexa7t2hf-neon-vfpv4.ipk
24 libpng16-16_1.6.37-r0_cortexa7t2hf-neon-vfpv4.ipk
25 libstdc++6_10.2.0-r0_cortexa7t2hf-neon-vfpv4.ipk
26 libtinfo5_6.2-r0_cortexa7t2hf-neon-vfpv4.ipk
27 libz1_1.2.11-r0_cortexa7t2hf-neon-vfpv4.ipk
28 modutils-initscripts_1.0-r7_cortexa7t2hf-neon-vfpv4.ipk
29 ncurses-terminfo-base_6.2-r0_cortexa7t2hf-neon-vfpv4.ipk
30 netbase_1:6.1-r0_cortexa7t2hf-neon-vfpv4.ipk
31 packagegroup-core-boot_1.0-r17_raspberrypi3.ipk
32 run-postinsts_1.0-r10_all.ipk
33 sysvinit-inittab_2.88dsf-r10_raspberrypi3.ipk
34 sysvinit-pidof_2.97-r0_cortexa7t2hf-neon-vfpv4.ipk
35 sysvinit_2.97-r0_cortexa7t2hf-neon-vfpv4.ipk
36 update-alternatives-opkg_0.4.3-r0_cortexa7t2hf-neon-vfpv4.ipk
37 update-rc.d_0.8-r0_all.ipk
38 userland_20201027-r0_cortexa7t2hf-neon-vfpv4.ipk

In my case my DISTRO_FEATURES include "x11" and this new "dispmanx".
"userland" also includes a bunch of dispmanx test programs such as
hello_tiger.bin that work as well.

> I'm not sure it makes a lot of sense to introduce a check for dispmanx to
> oe-core if nothing in oe-core ever defines that feature.
>

As I mentioned to Khem, I added this patch in order to support the changes
I made to the recipe for glmark2 in meta-openembedded. If those can be done
in a bbappend in the BSP layer then I'd be happy to re-asses, but I don't
think they can.

Maybe a better question is: does adding this DISTRO_FEATURE hurt anything
in oe-core?

[-- Attachment #2: Type: text/html, Size: 4165 bytes --]