Re: [OE-core] [PATCH] mesa.inc: add dispmanx support

Phil Blundell
2020-12-04T10:51:44Z

On Thu, Dec 03, 2020 at 05:35:23PM -0500, Trevor Woerner wrote:
> On Thu, Dec 3, 2020 at 5:25 PM Phil Blundell <pb@pbcl.net> wrote:
>
> > If we're talking about OpenGLES applications, wouldn't you already have
> > opengl in DISTRO_FEATURES?
> >
>
> Not necessarily.
>
> Adding opengl to DISTRO_FEATURES really means "enable a bunch of
> PACKAGECONFIGs all over the place because I need x11 and mesa with all the
> bells and whistles".

It sounds like there are a few things that have gone wrong here then.
Firstly, "opengl" in DISTRO_FEATURES isn't supposed to imply anything
about x11. If it does, that's just a bug. It should indeed enable opengl
support in other recipes, though. Can you give an example of the sort
of thing that's getting enabled there that you don't want?

But secondly, thinking about it again, there's no reason for mesa itself
to require opengl in DISTRO_FEATURES anyway. Mesa itself is what provides
the GL API so it clearly doesn't depend on it. I think that existing
DISTRO_FEATURE check in mesa is just bogus and should be removed entirely.

> As I mentioned to Khem, I added this patch in order to support the changes
> I made to the recipe for glmark2 in meta-openembedded. If those can be done
> in a bbappend in the BSP layer then I'd be happy to re-asses, but I don't
> think they can.

It's a bit hard to say anything intelligent about that without knowing what
the changes are. Can you summarise what the issue is?

> Maybe a better question is: does adding this DISTRO_FEATURE hurt anything
> in oe-core?

Clearly it doesn't actually break anything, but it's going to be a bit of
a maintenance burden because it won't be very obvious to anybody else
working on the recipes what it's supposed to mean.

p.