Re: [OE-core] [PATCH] ltp: fix rpc build error

["Kory Maincent" <kory.maincent@bootlin.com>]

Hello Konrad,

On Thu, 17 Dec 2020 11:03:39 +0100
Konrad Weihmann <kweihmann@outlook.com> wrote:

> On 17.12.20 10:55, Kory Maincent wrote:
> > Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> > ---
> >   meta/recipes-extended/ltp/ltp_20200930.bb | 6 +++---
> >   1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/meta/recipes-extended/ltp/ltp_20200930.bb
> > b/meta/recipes-extended/ltp/ltp_20200930.bb index 7acf15b360..9b17d68f67
> > 100644 --- a/meta/recipes-extended/ltp/ltp_20200930.bb
> > +++ b/meta/recipes-extended/ltp/ltp_20200930.bb
> > @@ -14,7 +14,7 @@ LIC_FILES_CHKSUM = "\
> >       file://utils/benchmark/kernbench-0.42/COPYING;md5=94d55d512a9ba36caa9b7df079bae19f
> > \ "
> >   
> > -DEPENDS = "attr libaio libcap acl openssl zip-native"
> > +DEPENDS = "attr libaio libcap acl openssl zip-native libtirpc"  
> 
> Can we have that as a PACKAGECONFIG entry, please? otherwise I think it 
> will change the behavior of the existing setups.

I assumed the tirpc was disable because they did not manage to build with
it "# ltp network/rpc test cases ftbfs when libtirpc is found".
But if you prefer I can add it to PACKAGECONFIG.

> Also the dependency has a `PROVIDES = "virtual/librpc"`, so I think 
> depending on virtual/librpc should be the safest way

Ok

> 
> >   DEPENDS_append_libc-musl = " fts "
> >   EXTRA_OEMAKE_append_libc-musl = " LIBC=musl "
> >   EXTRA_OECONF_append_libc-musl = " LIBS=-lfts "
> > @@ -44,12 +44,12 @@ TARGET_CC_ARCH += "${LDFLAGS}"
> >   
> >   export prefix = "/opt/${PN}"
> >   export exec_prefix = "/opt/${PN}"
> > +export libdir = "/usr/lib"
> > +export incdir = "/usr/include"  
> 
> Those should be ${libdir} and ${incdir} if I'm not mistaken

The exporting of ${prefix} change the value of ${libdir} and ${incdir}
therefore I set them up again. If I don't set it, pkgconfig can not find
libtirpc.

> 
> >   
> >   PACKAGECONFIG[numa] = "--with-numa, --without-numa, numactl,"  
> 
> 
> >   EXTRA_AUTORECONF += "-I ${S}/testcases/realtime/m4"
> >   EXTRA_OECONF = " --with-realtime-testsuite --with-open-posix-testsuite "
> > -# ltp network/rpc test cases ftbfs when libtirpc is found
> > -EXTRA_OECONF += " --without-tirpc "  
> 
> Should be part of a PACKAGECONFIG entry, with `--without-tirpc` being 
> the default

Ok,

Köry