From: "Denys Dmytriyenko" <denis@denix.org>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: Richard Purdie <richard.purdie@linuxfoundation.org>,
Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH 2/2] convert-overrides.py: handle few more cases of overrides
Date: Wed, 4 Aug 2021 12:07:14 -0400 [thread overview]
Message-ID: <20210804160714.GW1528@denix.org> (raw)
In-Reply-To: <CA+chaQfComiP6AtnyhFbcqbhxzjD8epMuxSbdDNYibDGjFtPOA@mail.gmail.com>
On Wed, Aug 04, 2021 at 04:29:45PM +0200, Martin Jansa wrote:
> Yes, I see the same in meta-oe and meta-webosose.
>
> It's easy to spot false translations in incremental conversion where the
> diff is relatively small, but doing initial conversion on big layer with
> this change already included might be more painful.
>
> On Wed, Aug 4, 2021 at 12:31 PM Richard Purdie <
> richard.purdie@linuxfoundation.org> wrote:
>
> > On Tue, 2021-08-03 at 21:28 -0400, Denys Dmytriyenko wrote:
> > > Add task-configure and few more supported values of TARGET_OS override.
> > >
> > > Signed-off-by: Denys Dmytriyenko <denis@denix.org>
> > > ---
> > > scripts/contrib/convert-overrides.py | 5 +++--
> > > 1 file changed, 3 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/scripts/contrib/convert-overrides.py
> > b/scripts/contrib/convert-overrides.py
> > > index 6505b18..23f63a2 100755
> > > --- a/scripts/contrib/convert-overrides.py
> > > +++ b/scripts/contrib/convert-overrides.py
> > > @@ -36,9 +36,10 @@ vars = vars + ["mipsarch", "x86-x32", "mips16e",
> > "microblaze", "e5500-64b", "mip
> > > vars = vars + ["class-native", "class-target", "class-cross-canadian",
> > "class-cross", "class-devupstream"]
> > > vars = vars + ["tune-", "pn-", "forcevariable"]
> > > vars = vars + ["libc-musl", "libc-glibc",
> > "libc-newlib","libc-baremetal"]
> > > -vars = vars + ["task-compile", "task-install", "task-clean",
> > "task-image-qa", "task-rm_work", "task-image-complete", "task-populate-sdk"]
> > > +vars = vars + ["task-configure", "task-compile", "task-install",
> > "task-clean", "task-image-qa", "task-rm_work", "task-image-complete",
> > "task-populate-sdk"]
> > > vars = vars + ["toolchain-clang", "mydistro", "nios2", "sdkmingw32",
> > "overrideone", "overridetwo"]
> > > vars = vars + ["linux-gnux32", "linux-muslx32", "linux-gnun32",
> > "mingw32", "poky", "darwin", "linuxstdbase"]
> > > +vars = vars + ["linux", "linux-gnueabi", "elf", "eabi"]
> >
> > I have reservations about linux and elf being here since this does lead to
> > a lot of false translations for OE-Core. Since OE-Core is now translated I
> > guess that isn't the driving factor so I'll probably take this but it is
> > worth
> > being aware of.
> >
> > I did just have to retest a translation of core so I now need to filter all
> > these out the diff...
Should I re-submit with 'linux' and 'elf' removed?
--
Denys
next prev parent reply other threads:[~2021-08-04 16:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-04 1:28 [PATCH 1/2] meta: convert nested overrides leftovers to new syntax Denys Dmytriyenko
2021-08-04 1:28 ` [PATCH 2/2] convert-overrides.py: handle few more cases of overrides Denys Dmytriyenko
2021-08-04 10:31 ` [OE-core] " Richard Purdie
2021-08-04 14:29 ` Martin Jansa
2021-08-04 16:07 ` Denys Dmytriyenko [this message]
2021-08-04 17:04 ` Richard Purdie
2021-08-04 17:16 ` Denys Dmytriyenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210804160714.GW1528@denix.org \
--to=denis@denix.org \
--cc=martin.jansa@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox