Re: [OE-core] [PATCH 02/55] binutils: do not build-depend on target flex/bison/zlib.

Alexander Kanavin
2021-08-22T13:52:01Z

[-- Attachment #1: Type: text/plain, Size: 3218 bytes --]

On Sun, 22 Aug 2021 at 15:06, Richard Purdie <
richard.purdie@linuxfoundation.org> wrote:

> > -DEPENDS += "flex bison zlib"
> > -
>
> This is something which has caused a lot of problems in the past. In
> particular,
> if something touches (patches( one of the pre-generated files or we use a
> git
> version of binutils this breaks. It also seemed to depend on the host
> version of
> patch used.
>
> For zlib, is the recipe using the binary only or the library? If the
> latter,
> that also proves problematic.
>
> I appreciate it may have passed autobuilder testing but I suspect that
> isn't
> enough for real work use.
>
> Also, the target version would still need these?
>
> I like the idea of streamlining dependencies but this one needs some
> further
> checks...
>

All three are already explicitly included as native dependencies for all
binutils variants and that has not changed:
binutils.inc:DEPENDS = "flex-native bison-native zlib-native
gnu-config-native autoconf-native"

For the target dependencies, flex installs:
akanavin@ubuntu1804-ty:~/poky/build/tmp/work/core2-64-poky-linux/flex/2.6.4-r0$
find sysroot-destdir/
sysroot-destdir/
sysroot-destdir/usr
sysroot-destdir/usr/lib
sysroot-destdir/usr/lib/libfl.so
sysroot-destdir/usr/lib/libfl.so.2
sysroot-destdir/usr/lib/flex
sysroot-destdir/usr/lib/libfl.so.2.0.0
sysroot-destdir/usr/include
sysroot-destdir/usr/include/FlexLexer.h
sysroot-destdir/usr/share
sysroot-destdir/sysroot-providers
sysroot-destdir/sysroot-providers/flex

Binutils source does not mention FlexLexer.h anywhere.

Bison installs:
akanavin@ubuntu1804-ty:~/poky/build/tmp/work/core2-64-poky-linux/bison/3.7.6-r0/sysroot-destdir$
find
.
./usr
./usr/lib
./usr/lib/liby.a
./usr/share
./usr/share/aclocal
./usr/share/aclocal/bison-i18n.m4
./usr/share/bison
./usr/share/bison/xslt
./usr/share/bison/xslt/bison.xsl
./usr/share/bison/xslt/xml2text.xsl
./usr/share/bison/xslt/xml2dot.xsl
./usr/share/bison/xslt/xml2xhtml.xsl
./usr/share/bison/m4sugar
./usr/share/bison/m4sugar/m4sugar.m4
./usr/share/bison/m4sugar/foreach.m4
./usr/share/bison/skeletons
./usr/share/bison/skeletons/variant.hh
./usr/share/bison/skeletons/stack.hh
./usr/share/bison/skeletons/traceon.m4
./usr/share/bison/skeletons/c++.m4
./usr/share/bison/skeletons/bison.m4
./usr/share/bison/skeletons/yacc.c
./usr/share/bison/skeletons/c++-skel.m4
./usr/share/bison/skeletons/d-skel.m4
./usr/share/bison/skeletons/README-D.txt
./usr/share/bison/skeletons/location.cc
./usr/share/bison/skeletons/java.m4
./usr/share/bison/skeletons/lalr1.cc
./usr/share/bison/skeletons/d.m4
./usr/share/bison/skeletons/c-like.m4
./usr/share/bison/skeletons/lalr1.java
./usr/share/bison/skeletons/lalr1.d
./usr/share/bison/skeletons/c-skel.m4
./usr/share/bison/skeletons/glr.c
./usr/share/bison/skeletons/c.m4
./usr/share/bison/skeletons/glr.cc
./usr/share/bison/skeletons/java-skel.m4
./usr/share/bison/README.md
./usr/share/bison/bison-default.css

And similarly, none of this is mentioned in the source.

Zlib however was dropped incorrectly (there's --with-system-zlib), I will
amend that, and write a better commit message.

Alex

[-- Attachment #2: Type: text/html, Size: 4229 bytes --]