From: "Seebs" <seebs@seebs.net>
To: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 5/6] pseudo_client: Make msg static in pseudo_op_client
Date: Thu, 9 Sep 2021 11:03:13 -0500 [thread overview]
Message-ID: <20210909110313.61a47c0f@seebsdell> (raw)
In-Reply-To: <20210909153614.1225570-5-richard.purdie@linuxfoundation.org>
On Thu, 9 Sep 2021 16:36:13 +0100
Richard Purdie <richard.purdie@linuxfoundation.org> wrote:
> - pseudo_msg_t msg = { .type = PSEUDO_MSG_OP };
> + static pseudo_msg_t msg;
> + msg = (pseudo_msg_t) { .type = PSEUDO_MSG_OP };
Looks good to me.
I'm honestly sort of stunned that the return of the local variable's
address caused a problem, even though it's theoretically undefined,
because it's only ever checked against is-null, but I'm also sort of
stunned that I got away with it for that long.
-s
next prev parent reply other threads:[~2021-09-09 16:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-09 15:36 [PATCH 1/6] test: Add missing test-statx test case Richard Purdie
2021-09-09 15:36 ` [PATCH 2/6] test-openat: Consider device as well as inode number Richard Purdie
2021-09-09 16:05 ` Seebs
2021-09-09 15:36 ` [PATCH 3/6] pseudo_client: Do not pass null argument to pseudo_diag() Richard Purdie
2021-09-09 16:04 ` Seebs
2021-09-09 15:36 ` [PATCH 4/6] ports/linux/guts: Add close_range wrapper for glibc 2.34 Richard Purdie
2021-09-09 15:36 ` [PATCH 5/6] pseudo_client: Make msg static in pseudo_op_client Richard Purdie
2021-09-09 16:03 ` Seebs [this message]
2021-09-09 15:36 ` [PATCH 6/6] ports/linux/guts: Add closefrom support for glibc 2.34 Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210909110313.61a47c0f@seebsdell \
--to=seebs@seebs.net \
--cc=openembedded-core@lists.openembedded.org \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox