Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Kory Maincent <kory.maincent@bootlin.com>
To: openembedded-core@lists.openembedded.org
Cc: thomas.petazzoni@bootlin.com, alex.kanavin@gmail.com, raj.khem@gmail.com
Subject: [OE-core][PATCH v2] icu: fix make_icudata dependencies
Date: Thu, 20 Jan 2022 17:54:55 +0100	[thread overview]
Message-ID: <20220120165455.42075-1-kory.maincent@bootlin.com> (raw)

The make_icudata task is set before the configure task then the
dependencies for this task are not populate yet.

Fixed it by setting the deptask flag to do_populate_sysroot. With this, the
do_populate_sysroot task of each item in DEPENDS must complete before
do_make_icudata can execute.

Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---

Change in v2:
Use deptask flag instead of setting manually the task dependencies with
depends flag.

 meta/recipes-support/icu/icu_70.1.bb | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/meta/recipes-support/icu/icu_70.1.bb b/meta/recipes-support/icu/icu_70.1.bb
index 0988ae8b8e..ff5e249e9d 100644
--- a/meta/recipes-support/icu/icu_70.1.bb
+++ b/meta/recipes-support/icu/icu_70.1.bb
@@ -123,6 +123,9 @@ EXTRA_OECONF:append:libc-musl = " ac_cv_func_strtod_l=no"
 PACKAGECONFIG ?= ""
 PACKAGECONFIG[make-icudata] = ",,,"
 
+# Add dependencies to make_icudata
+do_make_icudata[deptask] += "do_populate_sysroot"
+
 do_make_icudata:class-target () {
     ${@bb.utils.contains('PACKAGECONFIG', 'make-icudata', '', 'exit 0', d)}
     cd ${S}
-- 
2.25.1



             reply	other threads:[~2022-01-20 16:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-20 16:54 Kory Maincent [this message]
2022-01-20 19:05 ` [OE-core][PATCH v2] icu: fix make_icudata dependencies Alexander Kanavin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220120165455.42075-1-kory.maincent@bootlin.com \
    --to=kory.maincent@bootlin.com \
    --cc=alex.kanavin@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=raj.khem@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox