From: luca.boccassi@gmail.com
To: openembedded-core@lists.openembedded.org
Subject: [PATCH 1/2] mount-copybind: fix shellcheck warning
Date: Fri, 25 Mar 2022 18:40:31 +0000 [thread overview]
Message-ID: <20220325184032.1880706-1-luca.boccassi@gmail.com> (raw)
From: Luca Boccassi <bluca@debian.org>
$ shellcheck meta/recipes-core/volatile-binds/files/mount-copybind
In meta/recipes-core/volatile-binds/files/mount-copybind line 54:
mountcontext=",rootcontext=$(matchpathcon -n $mountpoint)"
^---------^ SC2086: Double quote to prevent globbing and word splitting.
Did you mean:
mountcontext=",rootcontext=$(matchpathcon -n "$mountpoint")"
For more information:
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
---
meta/recipes-core/volatile-binds/files/mount-copybind | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-core/volatile-binds/files/mount-copybind b/meta/recipes-core/volatile-binds/files/mount-copybind
index aad022c6e4..8bbb406b3a 100755
--- a/meta/recipes-core/volatile-binds/files/mount-copybind
+++ b/meta/recipes-core/volatile-binds/files/mount-copybind
@@ -48,7 +48,7 @@ if [ -d "$mountpoint" ]; then
# If that fails, fall back to slower copy.
if command -v selinuxenabled > /dev/null 2>&1; then
if selinuxenabled; then
- mountcontext=",rootcontext=$(matchpathcon -n $mountpoint)"
+ mountcontext=",rootcontext=$(matchpathcon -n "$mountpoint")"
fi
fi
if ! mount -t overlay overlay -olowerdir="$mountpoint",upperdir="$spec",workdir="$overlay_workdir""$mountcontext" "$mountpoint" > /dev/null 2>&1; then
--
2.34.1
next reply other threads:[~2022-03-25 18:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-25 18:40 luca.boccassi [this message]
2022-03-25 18:40 ` [PATCH 2/2] mount-copybind: add MOUNT_COPYBIND_AVOID_OVERLAYFS env var to skip OverlayFS luca.boccassi
2022-03-28 15:30 ` [OE-core] " Michael Opdenacker
2022-03-28 15:32 ` Luca Boccassi
2022-03-28 16:08 ` Michael Opdenacker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220325184032.1880706-1-luca.boccassi@gmail.com \
--to=luca.boccassi@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox