Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Luca Ceresoli <luca.ceresoli@bootlin.com>
To: "zhengruoqin" <zhengrq.fnst@fujitsu.com>
Cc: <openembedded-core@lists.openembedded.org>,
	Wang Mingyu <wangmy@fujitsu.com>
Subject: Re: [OE-core] [PATCH] sysvinit: upgrade 3.02 -> 3.03
Date: Thu, 21 Apr 2022 10:13:46 +0200	[thread overview]
Message-ID: <20220421101346.3b7774ea@melee> (raw)
In-Reply-To: <1650524435-13155-1-git-send-email-zhengrq.fnst@fujitsu.com>

Hi zhengruoqin,

Il giorno Thu, 21 Apr 2022 15:00:35 +0800
"zhengruoqin" <zhengrq.fnst@fujitsu.com> ha scritto:

> 0001-Fixed-compile-error-on-GNU-Hurd.patch
> removed since it's included in 3.03.
> 
> Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com>

Thank you for sending an update version of your patch, but I'm afraid
it does not apply, and this is for a weird reason, see below.

> diff --git
> a/meta/recipes-core/sysvinit/sysvinit/0001-Fixed-compile-error-on-GNU-Hurd.patch
> b/meta/recipes-core/sysvinit/sysvinit/0001-Fixed-compile-error-on-GNU-Hurd.patch
> deleted file mode 100644 index d278a32ec7..0000000000 ---
> a/meta/recipes-core/sysvinit/sysvinit/0001-Fixed-compile-error-on-GNU-Hurd.patch
> +++ /dev/null @@ -1,28 +0,0 @@
> -From d595594506e6fd2247f7984c276f822ea626434c Mon Sep 17 00:00:00
> -From: Zheng Ruoqin <zhengrq.fnst@fujitsu.com>

The patch currently in the repo has a different name here:

From: Wang Mingyu <wangmy@fujitsu.com>

> -Date: Thu, 7 Apr 2022 11:57:19 +0900
> -Subject: [PATCH] Fixed compile error on GNU Hurd
> -
> -Fixed compile error on GNU Hurd due to missing MAX_PATH definition.
> -
> -Upstream-Status: Backport
> [https://github.com/slicer69/sysvinit/commit/14d8d25269016b26965b428a855dd084cc88994d]
> - -Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com>

Same here.

Did you apply any mangling to the patch before sending? Please resend
without any mangling and I'll be glad to take your patch for testing.

Best regards.
-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


      reply	other threads:[~2022-04-21 16:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-21  7:00 [OE-core] [PATCH] sysvinit: upgrade 3.02 -> 3.03 zhengrq.fnst
2022-04-21  8:13 ` Luca Ceresoli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220421101346.3b7774ea@melee \
    --to=luca.ceresoli@bootlin.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=wangmy@fujitsu.com \
    --cc=zhengrq.fnst@fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox