Re: [OE-core] [PATCH v2] classes: rootfs-postcommands: add skip option to overlayfs_qa_check

[Luca Ceresoli <luca.ceresoli@bootlin.com>]

Hi Claudius,

Il giorno Fri, 29 Apr 2022 10:17:33 +0200
"Claudius Heine" <ch@denx.de> ha scritto:

> The overlayfs_qa_check checks if the current root file system has a
> mount configured for each overlayfs, when the overlayfs class is used.
> 
> However there are certain instances where this mount point is created
> at runtime and not static in a fstab entry or systemd mount unit.
> 
> One such case would be if overlayfs-etc is used, where the device is
> mounted in the preinit script and not via a mount unit or fstab entry.
> 
> However there are other possibilities for this as well, like startup
> scripts that support a dynamic partition layout. For instance when
> systemd-repart is used.
> 
> This adds the `OVERLAYFS_QA_SKIP` variable, which allows to define QA
> skips via its flags. In principle it supports multiple QA skip flags
> separated by whitespace, but only one (`mount-configured`) is
> implemented here. To skip this QA check simply add `mount-configured`
> to the flag of `OVERLAYFS_QA_SKIP` with the same name. For instance
> if a overlayfs is configured as:
> 
> 	OVERLAYFS_MOUNT_POINT[data] = "/data"
> 
> Skipping this QA check can be done by setting:
> 
> 	OVERLAYFS_QA_SKIP[data] = "mount-configured"
> 
> Signed-off-by: Claudius Heine <ch@denx.de>

Failures appeared on the autobuilders with your patch applied:

https://autobuilder.yoctoproject.org/typhoon/#/builders/87/builds/3530/steps/15/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/87/builds/3530/steps/15/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/80/builds/3470/steps/14/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/79/builds/3521/steps/15/logs/stdio

Best regards,
-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com