Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Luca Ceresoli <luca.ceresoli@bootlin.com>
To: Qorin Qorinna <qorin.qorinna@nl.abb.com>
Cc: Qorin Wu <qorin.wu@gmail.com>,
	"openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH] add missing normalize-resolvconf file since it has been moved to a separate file since version 1.90
Date: Mon, 20 Jun 2022 11:49:55 +0200	[thread overview]
Message-ID: <20220620114955.61d67615@booty> (raw)
In-Reply-To: <AM0PR06MB4625172F0F099B35BB980A7BD9B09@AM0PR06MB4625.eurprd06.prod.outlook.com>

Hi Qorin,

On Mon, 20 Jun 2022 09:24:22 +0000
Qorin Qorinna <qorin.qorinna@nl.abb.com> wrote:

> Hi Luca,
> 
> it's because the normalize-resolvconf requires sed.
> 
> These are the error messages that I got when I built the package w/o sed
> ERROR: resolvconf-1.91-r0 do_package_qa: QA Issue: /lib/resolvconf/normalize-resolvconf contained in package resolvconf requires /bin/sed, but no providers found in RDEPENDS:resolvconf? [file-rdeps]
> ERROR: resolvconf-1.91-r0 do_package_qa: Fatal QA errors were found, failing task.

I see. In this case it would be nice to add either a line to the commit
message or a comment in the .bb file, just to avoid others to wonder
why sed is needed.

I added a line to the commit message on my branch that I'm going to
test. It would be great if you could do so for future patches. Thanks!

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


  parent reply	other threads:[~2022-06-20  9:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-20  8:08 [PATCH] add missing normalize-resolvconf file since it has been moved to a separate file since version 1.90 Qorin
2022-06-20  9:20 ` [OE-core] " Luca Ceresoli
     [not found]   ` <AM0PR06MB4625172F0F099B35BB980A7BD9B09@AM0PR06MB4625.eurprd06.prod.outlook.com>
2022-06-20  9:49     ` Luca Ceresoli [this message]
2022-06-20 10:55       ` Peter Kjellerstedt
2022-06-20 13:15         ` Qorin Wu
2022-06-21  8:11 ` Luca Ceresoli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220620114955.61d67615@booty \
    --to=luca.ceresoli@bootlin.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=qorin.qorinna@nl.abb.com \
    --cc=qorin.wu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox