From: Luca Ceresoli <luca.ceresoli@bootlin.com>
To: "Markus Volk" <f_l_k@t-online.de>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [oe-core][PATCH 1/2] llvm: make LLVM_HAVE_OPT_VIEWER_MODULES optional
Date: Thu, 23 Jun 2022 09:40:37 +0200 [thread overview]
Message-ID: <20220623094037.2204a89a@booty> (raw)
In-Reply-To: <e74c83db-d4fd-8696-d00b-b19c19f9b42e@t-online.de>
Hi Markus,
On Wed, 22 Jun 2022 23:03:47 +0200
"Markus Volk" <f_l_k@t-online.de> wrote:
> Hi Luca,
>
> your commit message is way better than mine.
>
> One suggestion on your patch. I guess to be working on the target it
> would be needed to add python3-pygment and python3-pyyaml as runtime
> dependencies as well.
>
> PACKAGECONFIG[optviewer] = ",-DPY_PYGMENTS_FOUND=OFF -DPY_PYGMENTS_LEXERS_C_CPP_FOUND=OFF -DPY_YAML_FOUND=OFF,python3-pygments python3-pyyaml,python3-pygments python3-pyyaml"
Good catch. So if you are OK I will take care of this, send v2, test it
on the autobuilder where it did fail and if there is no surprise send it
to Richard.
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2022-06-23 7:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-22 17:32 [oe-core][PATCH 1/2] llvm: make LLVM_HAVE_OPT_VIEWER_MODULES optional Markus Volk
2022-06-22 17:32 ` [oe-core][PATCH 2/2] llvm: dont use host python Markus Volk
2022-06-22 20:44 ` [oe-core][PATCH 1/2] llvm: make LLVM_HAVE_OPT_VIEWER_MODULES optional Luca Ceresoli
2022-06-22 21:03 ` Markus Volk
2022-06-23 7:40 ` Luca Ceresoli [this message]
2022-06-23 7:57 ` Markus Volk
2022-06-23 8:41 ` Luca Ceresoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220623094037.2204a89a@booty \
--to=luca.ceresoli@bootlin.com \
--cc=f_l_k@t-online.de \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox