Re: [OE-core] [PATCHv2]] recipes-support: rng-tools change systemd service name

[Luca Ceresoli <luca.ceresoli@bootlin.com>]

Hello Aníbal,

On Tue, 26 Jul 2022 14:33:22 -0500
"An?bal Lim?n" <limon.anibal@gmail.com> wrote:

> From: Aníbal Limón <limon.anibal@gmail.com>
> 
> Change systemd service name from rngd -> rng-tools to avoid load twice
> the service when sysvinit compatibility is enabled,
> 
> ...
> root@:~# ps  | grep rng
>    23 root         0 SW   [hwrng]
> 13109 root      3528 R    /usr/sbin/rngd -f -r /dev/hwrng
> 13117 root      2348 S    grep rng
> 29418 root     12756 S    /usr/sbin/rngd -r /dev/hwrng
> ...
> 
> Signed-off-by: Aníbal Limón <limon.anibal@gmail.com>
> ---
>  .../rng-tools/{rngd.service => rng-tools.service}    |  0
>  meta/recipes-support/rng-tools/rng-tools_6.15.bb     | 12 ++++++------
>  2 files changed, 6 insertions(+), 6 deletions(-)
>  rename meta/recipes-support/rng-tools/rng-tools/{rngd.service => rng-tools.service} (100%)
> 
> diff --git a/meta/recipes-support/rng-tools/rng-tools/rngd.service b/meta/recipes-support/rng-tools/rng-tools/rng-tools.service
> similarity index 100%
> rename from meta/recipes-support/rng-tools/rng-tools/rngd.service
> rename to meta/recipes-support/rng-tools/rng-tools/rng-tools.service
> diff --git a/meta/recipes-support/rng-tools/rng-tools_6.15.bb b/meta/recipes-support/rng-tools/rng-tools_6.15.bb
> index 0696351903..efc08b5e0a 100644
> --- a/meta/recipes-support/rng-tools/rng-tools_6.15.bb
> +++ b/meta/recipes-support/rng-tools/rng-tools_6.15.bb
> @@ -11,7 +11,7 @@ DEPENDS = "sysfsutils openssl"
>  SRC_URI = "git://github.com/nhorman/rng-tools.git;branch=master;protocol=https \
>             file://init \
>             file://default \
> -           file://rngd.service \
> +           file://rng-tools.service \

This feels strange to me: "rng-tools" does not look like a daemon name,
but rather a, well, tools name. Maybe "rng-daemon" would clarify?

Still I'm taking this patch for testing, I'll replace it with v2 should
you send one.

However please note there is an extra ']' in the subject: [PATCHv2]]
should be [PATCHv2]. This leads 'git am' to produce a commit starting
with a "] " prefix. I fixed it while applying, however you should check
that in the future.

Best regards.
-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com