Re: [oe-core][PATCH] connman: add PACKAGECONFIG to support iwd

[Luca Ceresoli <luca.ceresoli@bootlin.com>]

Hello Markus,

On Tue, 23 Aug 2022 18:38:09 +0200
"Markus Volk" <f_l_k@t-online.de> wrote:

> Signed-off-by: Markus Volk <f_l_k@t-online.de>
> ---
>  meta/recipes-connectivity/connman/connman.inc | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-connectivity/connman/connman.inc b/meta/recipes-connectivity/connman/connman.inc
> index 5880ecd5d4..d73a2a734f 100644
> --- a/meta/recipes-connectivity/connman/connman.inc
> +++ b/meta/recipes-connectivity/connman/connman.inc
> @@ -28,10 +28,15 @@ EXTRA_OECONF += "\
>      --enable-tools \
>      --disable-polkit \
>  "
> +# For smooth operation it would be best to start only one wireless daemon at a time.
> +# If wpa_supplicant is running, connman will use it preferentially.
> +# Select either wpa_supplicant or iwd
> +WIRELESS_DAEMON ??= "wpa_supplicant"
>  
>  PACKAGECONFIG ??= "wispr iptables client\
> -                   ${@bb.utils.filter('DISTRO_FEATURES', '3g systemd wifi', d)} \
> +                   ${@bb.utils.filter('DISTRO_FEATURES', '3g systemd', d)} \
>                     ${@bb.utils.contains('DISTRO_FEATURES', 'bluetooth', 'bluez', '', d)} \
> +                   ${@bb.utils.contains('DISTRO_FEATURES', 'wifi', 'wifi ${WIRELESS_DAEMON}', '', d)} \
>  "
>  
>  # If you want ConnMan to support VPN, add following statement into
> @@ -39,9 +44,11 @@ PACKAGECONFIG ??= "wispr iptables client\
>  # PACKAGECONFIG:append:pn-connman = " openvpn vpnc l2tp pptp"
>  
>  PACKAGECONFIG[systemd] = "--with-systemdunitdir=${systemd_system_unitdir}/ --with-tmpfilesdir=${sysconfdir}/tmpfiles.d/,--with-systemdunitdir='' --with-tmpfilesdir=''"
> -PACKAGECONFIG[wifi] = "--enable-wifi, --disable-wifi, wpa-supplicant, wpa-supplicant"
> +PACKAGECONFIG[wifi] = "--enable-wifi, --disable-wifi"
>  PACKAGECONFIG[bluez] = "--enable-bluetooth, --disable-bluetooth, bluez5, bluez5"
>  PACKAGECONFIG[3g] = "--enable-ofono, --disable-ofono, ofono, ofono"
> +PACKAGECONFIG[wpa_supplicant] = ",,wpa-supplicant,wpa-supplicant"
> +PACKAGECONFIG[iwd] = "--enable-iwd,--disable-iwd,,,iwd"

I would think iwd should be an rdepends, not an rrecommends. Any reson
for that? Or is it just an unintended extra ','?

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com