public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Alejandro Enedino Hernandez Samaniego <alejandro@enedino.org>
To: openembedded-core@lists.openembedded.org
Cc: Alejandro Enedino Hernandez Samaniego <alejandro@enedino.org>
Subject: [PATCH] baremetal-image.bbclass: avoid inheriting incompatible IMAGE_CLASSES
Date: Thu,  1 Sep 2022 17:42:06 -0600	[thread overview]
Message-ID: <20220901234206.419429-1-alejandro@enedino.org> (raw)

There could be IMAGE_CLASSES designed to work on images which arent
necessarily compatible with baremetal-images, one example is the
license_image class which relies on the package managers functionality
during do_rootfs, for baremetal images no rootfs is created hence the
package manager shouldnt be invoked, we need to avoid inheriting such
class to fix this behavior.

inherit BAREMETAL_IMAGE_CLASSES for baremetal images but set the default
to IMAGE_CLASSES, whilst removing undesired classes in an intermediate
step to avoid incompatibilities.

Signed-off-by: Alejandro Enedino Hernandez Samaniego <alejandro@enedino.org>
---
 meta/classes-recipe/baremetal-image.bbclass | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/meta/classes-recipe/baremetal-image.bbclass b/meta/classes-recipe/baremetal-image.bbclass
index d3377a92fa..2f07dec4ac 100644
--- a/meta/classes-recipe/baremetal-image.bbclass
+++ b/meta/classes-recipe/baremetal-image.bbclass
@@ -18,8 +18,15 @@
 ## Emulate image.bbclass
 # Handle inherits of any of the image classes we need
 IMAGE_CLASSES ??= ""
-IMGCLASSES = " ${IMAGE_CLASSES}"
+BAREMETAL_IMAGE_CLASSES ?= " ${IMAGE_CLASSES}"
+
+# The license_image class relies on package managers used on do_rootfs
+# these dont exist for baremetal images since no rootfs is created.
+BAREMETAL_IMAGE_CLASSES:remove = "license_image"
+
+IMGCLASSES = " ${BAREMETAL_IMAGE_CLASSES}"
 inherit ${IMGCLASSES}
+
 # Set defaults to satisfy IMAGE_FEATURES check
 IMAGE_FEATURES ?= ""
 IMAGE_FEATURES[type] = "list"
-- 
2.25.1



             reply	other threads:[~2022-09-01 23:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-01 23:42 Alejandro Enedino Hernandez Samaniego [this message]
2022-09-02 14:47 ` [OE-core] [PATCH] baremetal-image.bbclass: avoid inheriting incompatible IMAGE_CLASSES Richard Purdie
2022-09-02 14:53   ` Alejandro Enedino Hernandez Samaniego
2022-09-02 15:02     ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220901234206.419429-1-alejandro@enedino.org \
    --to=alejandro@enedino.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox