public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Vyacheslav Yurkov <uvv.mail@gmail.com>
To: openembedded-core@lists.openembedded.org
Cc: Vyacheslav Yurkov <v.yurkov@precitec.de>
Subject: [PATCH 1/5] oeqa/selftest: drop image_feature test from overlayfs
Date: Wed,  7 Sep 2022 21:51:35 +0200	[thread overview]
Message-ID: <20220907195139.814465-1-uvv.mail@gmail.com> (raw)

From: Vyacheslav Yurkov <v.yurkov@precitec.de>

The test checked the incorrect class use with INHERIT. This
functionality is now covered by bitbake

Signed-off-by: Vyacheslav Yurkov <v.yurkov@precitec.de>
---
 meta/lib/oeqa/selftest/cases/overlayfs.py | 13 +------------
 1 file changed, 1 insertion(+), 12 deletions(-)

diff --git a/meta/lib/oeqa/selftest/cases/overlayfs.py b/meta/lib/oeqa/selftest/cases/overlayfs.py
index bff22f21b6..f550015b4b 100644
--- a/meta/lib/oeqa/selftest/cases/overlayfs.py
+++ b/meta/lib/oeqa/selftest/cases/overlayfs.py
@@ -333,24 +333,14 @@ EXTRA_IMAGE_FEATURES += "package-management"
         self.assertTrue("overlayfs-etc" in res.output, msg=res.output)
         self.assertTrue("package-management" in res.output, msg=res.output)
 
-    def test_image_feature_is_missing_class_included(self):
-        configAppend = """
-INHERIT += "overlayfs-etc"
-"""
-        self.run_check_image_feature(configAppend)
-
     def test_image_feature_is_missing(self):
-        self.run_check_image_feature()
-
-    def run_check_image_feature(self, appendToConfig=""):
         """
         Summary:   Overlayfs-etc class is not applied when image feature is not set
-                   even if we inherit it directly,
         Expected:  Image is created successfully but /etc is not an overlay
         Author:    Vyacheslav Yurkov <uvv.mail@gmail.com>
         """
 
-        config = f"""
+        config = """
 DISTRO_FEATURES:append = " systemd"
 
 # Use systemd as init manager
@@ -366,7 +356,6 @@ EXTRA_IMAGE_FEATURES += "read-only-rootfs"
 # Image configuration for overlayfs-etc
 OVERLAYFS_ETC_MOUNT_POINT = "/data"
 OVERLAYFS_ETC_DEVICE = "/dev/sda3"
-{appendToConfig}
 """
 
         self.write_config(config)
-- 
2.30.2



             reply	other threads:[~2022-09-07 19:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-07 19:51 Vyacheslav Yurkov [this message]
2022-09-07 19:51 ` [PATCH 2/5] classes: Update overlayfs classes to use new bitbake functionality Vyacheslav Yurkov
2022-09-07 19:51 ` [PATCH 3/5] files: overlayfs-etc: refactor preinit template Vyacheslav Yurkov
2022-09-07 19:51 ` [PATCH 4/5] classes: files: Extend overlayfs-etc class Vyacheslav Yurkov
2022-09-07 19:51 ` [PATCH 5/5] oeqa/selftest: Add lower layer test for overlayfs-etc Vyacheslav Yurkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220907195139.814465-1-uvv.mail@gmail.com \
    --to=uvv.mail@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=v.yurkov@precitec.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox