From: Mikko Rapeli <mikko.rapeli@linaro.org>
To: openembedded-core@lists.openembedded.org, docs@lists.yoctoproject.org
Cc: Mikko Rapeli <mikko.rapeli@linaro.org>
Subject: [PATCH 2/7] kernel-dev/common.rst: remove SRC_URI:append from examples
Date: Mon, 12 Sep 2022 10:32:16 +0300 [thread overview]
Message-ID: <20220912073221.16601-2-mikko.rapeli@linaro.org> (raw)
In-Reply-To: <20220912073221.16601-1-mikko.rapeli@linaro.org>
It's better to use SRC_URI += to append patches etc. If anything
is added via :append, that can no longer be removed at all.
If common, re-usable layers use SRC_URI:append, then users can
not change those patches or SRC_URI entries without completely
replacing the recipe with a copy in their own layer. Thus
+= is better.
Signed-off-by: Mikko Rapeli <mikko.rapeli@linaro.org>
---
documentation/kernel-dev/common.rst | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/documentation/kernel-dev/common.rst b/documentation/kernel-dev/common.rst
index 16ef6453bd..fb8d7cd029 100644
--- a/documentation/kernel-dev/common.rst
+++ b/documentation/kernel-dev/common.rst
@@ -360,9 +360,9 @@ home directory:
FILESEXTRAPATHS:prepend := "${THISDIR}/${PN}:"
- SRC_URI:append = " file://patch-file-one.patch"
- SRC_URI:append = " file://patch-file-two.patch"
- SRC_URI:append = " file://patch-file-three.patch"
+ SRC_URI += "file://patch-file-one.patch"
+ SRC_URI += "file://patch-file-two.patch"
+ SRC_URI += "file://patch-file-three.patch"
The :term:`FILESEXTRAPATHS` and :term:`SRC_URI` statements
enable the OpenEmbedded build system to find patch files. For more
@@ -1002,7 +1002,7 @@ Section.
contents::
FILESEXTRAPATHS:prepend := "${THISDIR}/${PN}:"
- SRC_URI:append = " file://0001-calibrate.c-Added-some-printk-statements.patch"
+ SRC_URI += "file://0001-calibrate.c-Added-some-printk-statements.patch"
The :term:`FILESEXTRAPATHS` and :term:`SRC_URI` statements
enable the OpenEmbedded build system to find the patch file.
@@ -1875,7 +1875,7 @@ build.
2. *Add the Feature File to SRC_URI:* Add the ``.scc`` file to the
recipe's :term:`SRC_URI` statement::
- SRC_URI:append = " file://test.scc"
+ SRC_URI += "file://test.scc"
The leading space before the path is important as the path is
appended to the existing path.
@@ -1884,7 +1884,7 @@ build.
:term:`KERNEL_FEATURES` statement to specify the feature as a kernel
feature::
- KERNEL_FEATURES:append = " test.scc"
+ KERNEL_FEATURES += "test.scc"
The OpenEmbedded build
system processes the kernel feature when it builds the kernel.
--
2.17.1
next prev parent reply other threads:[~2022-09-12 7:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-12 7:32 [PATCH 1/7] common-tasks.rst: remove SRC_URI:append from examples Mikko Rapeli
2022-09-12 7:32 ` Mikko Rapeli [this message]
2022-09-12 7:32 ` [PATCH 3/7] u-boot: switch from append to += in SRC_URI Mikko Rapeli
2022-09-12 7:32 ` [PATCH 4/7] glibc-tests: use += instead of :append Mikko Rapeli
2022-09-12 7:32 ` [PATCH 5/7] go-native: switch from SRC_URI:append to SRC_URI += Mikko Rapeli
2022-09-12 7:32 ` [PATCH 6/7] python3-rfc3986-validator: " Mikko Rapeli
2022-09-12 7:32 ` [PATCH 7/7] linux-libc-headers: " Mikko Rapeli
2022-09-19 15:04 ` [docs] [PATCH 1/7] common-tasks.rst: remove SRC_URI:append from examples Quentin Schulz
2022-09-19 20:35 ` [OE-core] " Michael Opdenacker
2022-09-20 7:34 ` Mikko Rapeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220912073221.16601-2-mikko.rapeli@linaro.org \
--to=mikko.rapeli@linaro.org \
--cc=docs@lists.yoctoproject.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox