From: Luca Ceresoli <luca.ceresoli@bootlin.com>
To: "Mikko Rapeli" <mikko.rapeli@linaro.org>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH v2 3/5] u-boot: use openssl-native.bbclass
Date: Tue, 4 Oct 2022 23:57:19 +0200 [thread overview]
Message-ID: <20221004235719.0e2bd17b@booty> (raw)
In-Reply-To: <20221004152807.987313-1-mikko.rapeli@linaro.org>
Hello Mikko,
On Tue, 4 Oct 2022 18:28:07 +0300
"Mikko Rapeli" <mikko.rapeli@linaro.org> wrote:
> It sets all environment variables correctly for openssl-native.
>
> Signed-off-by: Mikko Rapeli <mikko.rapeli@linaro.org>
I'm taking this patch for testing, however I have a question, see below.
> ---
> meta/recipes-bsp/u-boot/u-boot.inc | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-bsp/u-boot/u-boot.inc b/meta/recipes-bsp/u-boot/u-boot.inc
> index f022aed732..cd9c578962 100644
> --- a/meta/recipes-bsp/u-boot/u-boot.inc
> +++ b/meta/recipes-bsp/u-boot/u-boot.inc
> @@ -17,7 +17,8 @@ PACKAGECONFIG ??= "openssl"
> # u-boot will compile its own tools during the build, with specific
> # configurations (aka when CONFIG_FIT_SIGNATURE is enabled) openssl is needed as
> # a host build dependency.
> -PACKAGECONFIG[openssl] = ",,openssl-native"
> +OPENSSL_INHERIT .= "${@bb.utils.contains('PACKAGECONFIG', 'openssl', 'openssl-native', '', d)}"
What is the reason to use '.=' and not just '=' here?
> +inherit ${OPENSSL_INHERIT}
>
> # Allow setting an additional version string that will be picked up by the
> # u-boot build system and appended to the u-boot version. If the .scmversion
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2022-10-04 21:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-04 15:28 [PATCH v2 3/5] u-boot: use openssl-native.bbclass Mikko Rapeli
2022-10-04 21:57 ` Luca Ceresoli [this message]
2022-10-05 6:02 ` [OE-core] " Mikko Rapeli
2022-10-05 8:03 ` Peter Kjellerstedt
2022-10-05 16:50 ` Luca Ceresoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221004235719.0e2bd17b@booty \
--to=luca.ceresoli@bootlin.com \
--cc=mikko.rapeli@linaro.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox