From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B6C7C00A5A for ; Thu, 19 Jan 2023 09:52:40 +0000 (UTC) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by mx.groups.io with SMTP id smtpd.web10.41808.1674121955618232887 for ; Thu, 19 Jan 2023 01:52:36 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=p0c0JxJY; spf=pass (domain: bootlin.com, ip: 217.70.183.193, mailfrom: luca.ceresoli@bootlin.com) Received: from booty (unknown [77.244.183.192]) (Authenticated sender: luca.ceresoli@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id A099A240018; Thu, 19 Jan 2023 09:52:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1674121953; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YsaLrqNELraHIyzWxcDUL8P4ABCNOotuKQ5nWjrPq/8=; b=p0c0JxJY/qOYpSEhbFuYNQYypdkLVeWA64OQW2I6M++L5LzqLulJY46t4eBz9xnzSNALFG 0lS8dsVTDIMfRMbT9vruP8zrMhoJqNWTiBqwTbzqkSnomPI+wLIlkm1/eMxtoSA2LG4cl4 fkwntYqTRERgg9MCjh/rDmKrJow1qJU42ncHT5E9P2kEG29hMDqY39JKv/rTEo7pj6Nr90 1dL5/jwbeHPblbhKhSsJUDMMY5m4flLVsyQlRbdY+lH1I54IxjwukJ1cuhi9MgxyB8Nsjs 9by6mkoEEz7de+NUjy7qtIIb4qRRjT6ryleUBJHaksZ0ed0SommEc7HISmX9WA== Date: Thu, 19 Jan 2023 10:52:29 +0100 From: Luca Ceresoli To: "Luca Ceresoli via lists.openembedded.org" , Bruce Ashfield Cc: luca.ceresoli@bootlin.com, "Richard Purdie" , Jan-Simon =?UTF-8?Q?M=C3=B6ller?= , Anuj Mittal , openembedded-core@lists.openembedded.org Subject: Re: [OE-core] [PATCH 1/3] insane: Improve patch warning/error handling Message-ID: <20230119105229.1df0eaec@booty> In-Reply-To: <173BAB83B1A056B8.24231@lists.openembedded.org> References: <20230118142221.1926666-1-richard.purdie@linuxfoundation.org> <173BAB83B1A056B8.24231@lists.openembedded.org> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Thu, 19 Jan 2023 09:52:40 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/176132 Hello, On Thu, 19 Jan 2023 10:24:23 +0100 "Luca Ceresoli via lists.openembedded.org" wrote: > Hello Richard, > > On Wed, 18 Jan 2023 14:22:19 +0000 > "Richard Purdie" wrote: > > > Currently, whilst patch errors or warnings are shown, the errors don't stop builds. > > The configuration isn't very configurable from WARN_QA and ERROR_QA either. > > > > This patch: > > * Uses the standard mechanisms to handle the patch fuzz warnings/errors > > * Makes Upstream-Status checking configurable from WARN/ERROR_QA > > * Allows that checking to be used with non-core layers > > * Makes patch-fuzz an error by default > > * Enables warnings for missing Upstream-Status in non-core layer patches by default > > > > Signed-off-by: Richard Purdie > > --- > > meta/classes-global/insane.bbclass | 27 ++++++++++++++++++--------- > > 1 file changed, 18 insertions(+), 9 deletions(-) > > > > diff --git a/meta/classes-global/insane.bbclass b/meta/classes-global/insane.bbclass > > index ada8a7ef4e4..e1295f85392 100644 > > --- a/meta/classes-global/insane.bbclass > > +++ b/meta/classes-global/insane.bbclass > > @@ -29,11 +29,12 @@ > > WARN_QA ?= " libdir xorg-driver-abi buildpaths \ > > textrel incompatible-license files-invalid \ > > infodir build-deps src-uri-bad symlink-to-sysroot multilib \ > > - invalid-packageconfig host-user-contaminated uppercase-pn patch-fuzz \ > > + invalid-packageconfig host-user-contaminated uppercase-pn \ > > mime mime-xdg unlisted-pkg-lics unhandled-features-check \ > > missing-update-alternatives native-last missing-ptest \ > > license-exists license-no-generic license-syntax license-format \ > > license-incompatible license-file-missing obsolete-license \ > > + patch-status-noncore \ > > AB testing with this patch applied revealed a few Upstream-Status > warnings: > > - 5 in meta-agl-core: > https://autobuilder.yoctoproject.org/typhoon/#/builders/120/builds/2272/steps/13/logs/stdio > > - 3 in meta-intel: > https://autobuilder.yoctoproject.org/typhoon/#/builders/100/builds/3968/steps/13/logs/stdio And I missed: - 9 in meta-virtualization: https://autobuilder.yoctoproject.org/typhoon/#/builders/128/builds/1168/steps/13/logs/stdio > Jan-Simon, Anuj, can you look at those patches and maybe fix the Upstream-Status? Bruce is in the list too now :) Apologies for the noise. -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com