Re: [OE-core] [PATCH v3 1/4] dtc: version bump and add python wrapper

[Trevor Woerner <twoerner@gmail.com>]

Hi Quentin,

On Thu 2023-02-16 @ 10:23:07 AM, Quentin Schulz wrote:
> Hi Trevor,
> 
> On 2/14/23 19:30, Trevor Woerner wrote:
> > Bump the version of dtc from 1.6.1 to to 1.7.0.
> > 
> > Add support for building the python wrapper around libfdt.
> > 
> > Signed-off-by: Trevor Woerner <twoerner@gmail.com>
> > ---
> >   ...tdump-fix-Werror-int-to-pointer-cast.patch | 40 -------------------
> >   meta/recipes-kernel/dtc/dtc/0001-meson.patch  | 37 +++++++++++++++++
> >   .../dtc/{dtc_1.6.1.bb => dtc_1.7.0.bb}        | 18 +++++----
> >   3 files changed, 48 insertions(+), 47 deletions(-)
> >   delete mode 100644 meta/recipes-kernel/dtc/dtc/0001-fdtdump-fix-Werror-int-to-pointer-cast.patch
> >   create mode 100644 meta/recipes-kernel/dtc/dtc/0001-meson.patch
> >   rename meta/recipes-kernel/dtc/{dtc_1.6.1.bb => dtc_1.7.0.bb} (51%)
> > 
> > diff --git a/meta/recipes-kernel/dtc/dtc/0001-fdtdump-fix-Werror-int-to-pointer-cast.patch b/meta/recipes-kernel/dtc/dtc/0001-fdtdump-fix-Werror-int-to-pointer-cast.patch
> > deleted file mode 100644
> > index 4c3e34b1ffd2..000000000000
> > --- a/meta/recipes-kernel/dtc/dtc/0001-fdtdump-fix-Werror-int-to-pointer-cast.patch
> > +++ /dev/null
> > @@ -1,40 +0,0 @@
> > -Fix the build of fdtdump with mingw.
> > -
> > -Upstream-Status: Backport
> > -Signed-off-by: Ross Burton <ross.burton@arm.com>
> > -
> > -From ae0ce1fa7f4d679b5f8df1fc0e797246e43547fe Mon Sep 17 00:00:00 2001
> > -From: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= <marcandre.lureau@redhat.com>
> > -Date: Wed, 25 Aug 2021 16:13:50 +0400
> > -Subject: [PATCH] fdtdump: fix -Werror=int-to-pointer-cast
> > -MIME-Version: 1.0
> > -Content-Type: text/plain; charset=UTF-8
> > -Content-Transfer-Encoding: 8bit
> > -
> > -With mingw64-gcc, the compiler complains with various warnings:
> > -error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
> > -
> > -Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> > -Message-Id: <20210825121350.213551-1-marcandre.lureau@redhat.com>
> > -Acked-by: Rob Herring <robh@kernel.org>
> > -Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> > ----
> > - fdtdump.c | 2 +-
> > - 1 file changed, 1 insertion(+), 1 deletion(-)
> > -
> > -diff --git a/fdtdump.c b/fdtdump.c
> > -index d9fb374..483f367 100644
> > ---- a/fdtdump.c
> > -+++ b/fdtdump.c
> > -@@ -21,7 +21,7 @@
> > - #define MAX_VERSION 17
> > -
> > - #define ALIGN(x, a)	(((x) + ((a) - 1)) & ~((a) - 1))
> > --#define PALIGN(p, a)	((void *)(ALIGN((unsigned long)(p), (a))))
> > -+#define PALIGN(p, a)	((void *)(ALIGN((uintptr_t)(p), (a))))
> > - #define GET_CELL(p)	(p += 4, *((const fdt32_t *)(p-4)))
> > -
> > - static const char *tagname(uint32_t tag)
> > ---
> > -2.25.1
> > -
> > diff --git a/meta/recipes-kernel/dtc/dtc/0001-meson.patch b/meta/recipes-kernel/dtc/dtc/0001-meson.patch
> > new file mode 100644
> > index 000000000000..10c4f8706194
> > --- /dev/null
> > +++ b/meta/recipes-kernel/dtc/dtc/0001-meson.patch
> > @@ -0,0 +1,37 @@
> > +From faa02d4a60859089017bf92e0e3f49d600c44d73 Mon Sep 17 00:00:00 2001
> > +From: Trevor Woerner <twoerner@gmail.com>
> > +Date: Sun, 12 Feb 2023 14:37:04 -0500
> > +Subject: [PATCH] allow pylibfdt in cross
> > +
> > +Allow pylibfdt to be built even in cross-development scenarios.
> > +
> > +Upstream-Status: Inappropriate [embedded specific]
> > +
> 
> Is this really inappropriate? Cross-compilation is not THAT niche anymore
> that people aren't open to support it?

I guess not. The way I looked at it was: they put in an explicit condition to
not cross-compile, I guess they know what they're doing ;-)

> What about opening an issue/ticket
> upstream and see what they tell us?

Yes, I will do that.

> Or do you already have such info, in
> which case can you give a link to this justification here?
> 
> Cheers,
> Quentin