public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: "Petr Kubizňák" <kubiznak@2n.com>
To: <openembedded-core@lists.openembedded.org>
Cc: "Petr Kubizňák" <kubiznak@2n.com>
Subject: [OE-core][PATCH v3 1/6] gobject-introspection: reduce dependencies
Date: Fri, 24 Mar 2023 16:22:33 +0100	[thread overview]
Message-ID: <20230324152238.194877-1-kubiznak@2n.com> (raw)

When GI_DATA_ENABLED is 'False' (e.g. because
'gobject-introspection-data' is not in DISTRO_FEATURES),
gobject-introspection, gobject-introspection-native and qemu-native
should not be added to DEPENDS. This is to reduce dependency chain
when g-i is disabled.

Signed-off-by: Petr Kubizňák <kubiznak@2n.com>
---
 meta/classes-recipe/gobject-introspection.bbclass | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/meta/classes-recipe/gobject-introspection.bbclass b/meta/classes-recipe/gobject-introspection.bbclass
index 0c7b7d200a..98edb93761 100644
--- a/meta/classes-recipe/gobject-introspection.bbclass
+++ b/meta/classes-recipe/gobject-introspection.bbclass
@@ -35,7 +35,7 @@ EXTRA_OEMESON:prepend:class-nativesdk = "${@['', '${GIRMESONBUILD}'][d.getVar('G
 
 # Generating introspection data depends on a combination of native and target
 # introspection tools, and qemu to run the target tools.
-DEPENDS:append:class-target = " gobject-introspection gobject-introspection-native qemu-native"
+DEPENDS:append:class-target = " ${@bb.utils.contains('GI_DATA_ENABLED', 'True', 'gobject-introspection gobject-introspection-native qemu-native', '', d)}"
 
 # Even though introspection is disabled on -native, gobject-introspection package is still
 # needed for m4 macros.
@@ -46,10 +46,12 @@ DEPENDS:append:class-nativesdk = " gobject-introspection-native"
 export XDG_DATA_DIRS = "${STAGING_DATADIR}:${STAGING_LIBDIR}"
 
 do_configure:prepend:class-target () {
-    # introspection.m4 pre-packaged with upstream tarballs does not yet
-    # have our fixes
-    mkdir -p ${S}/m4
-    cp ${STAGING_DIR_TARGET}/${datadir}/aclocal/introspection.m4 ${S}/m4
+    if [ "${@bb.utils.contains('GI_DATA_ENABLED', 'True', '1', '0', d)}" = "1" ] ; then
+        # introspection.m4 pre-packaged with upstream tarballs does not yet
+        # have our fixes
+        mkdir -p ${S}/m4
+        cp ${STAGING_DIR_TARGET}/${datadir}/aclocal/introspection.m4 ${S}/m4
+    fi
 }
 
 # .typelib files are needed at runtime and so they go to the main package (so
-- 
2.30.2



             reply	other threads:[~2023-03-24 15:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-24 15:22 Petr Kubizňák [this message]
2023-03-24 15:22 ` [OE-core][PATCH v3 2/6] graphene: add gobject-types PACKAGECONFIG Petr Kubizňák
2023-03-24 15:22 ` [OE-core][PATCH v3 3/6] python3-pygobject: depend on gobject-introspection Petr Kubizňák
2023-03-24 15:46   ` Tim Orling
     [not found]   ` <174F6583B00F6A21.25304@lists.openembedded.org>
2023-03-24 15:48     ` Tim Orling
2023-03-24 15:22 ` [OE-core][PATCH v3 4/6] gconf: depend on glib-2.0-native Petr Kubizňák
2023-03-24 15:22 ` [OE-core][PATCH v3 5/6] avahi: " Petr Kubizňák
2023-03-24 15:22 ` [OE-core][PATCH v3 6/6] webkitgtk: add missing dependencies Petr Kubizňák
2023-03-28  7:22 ` [OE-core][PATCH v3 1/6] gobject-introspection: reduce dependencies Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230324152238.194877-1-kubiznak@2n.com \
    --to=kubiznak@2n.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox