public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Patrick Williams <patrick@stwcx.xyz>
To: openembedded-core@lists.openembedded.org
Cc: Patrick Williams <patrick@stwcx.xyz>
Subject: [PATCH] perl-version: make PERL* assignments non-immediate
Date: Tue,  4 Apr 2023 19:38:50 -0500	[thread overview]
Message-ID: <20230405003850.384813-1-patrick@stwcx.xyz> (raw)

The perl-version.bbclass executes functions which can depend on
variables potentially populated by native, such as `libdir`.  The
sanity `native-last` suggests that recipes should `inherit native`
last, but when that is done the variables like PERLVERSION end up
as `None`, since `${STAGING_LIBDIR}` needs `${libdir}` which is not
yet populated (by native).

Switch these variables to be non-immediate, which then allows the
`${libdir}` to be properly populated.

It appears that meta-openembedded/meta-perl does not use either
PERLVERSION or PERLARCH, nor is it used anywhere in `poky`.
meta-security/meta-perl uses PERLVERSION in one recipe's `do_install`
step.  OpenBMC's meta-phosphor similarly uses PERLVERSION in a
`do_install` step.  Therefore, it should be safe to make this
non-immediate.

Fixes: openbmc/openbmc#3770
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
---
 meta/classes-recipe/perl-version.bbclass | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/classes-recipe/perl-version.bbclass b/meta/classes-recipe/perl-version.bbclass
index 269ac9eb31..e4913dd502 100644
--- a/meta/classes-recipe/perl-version.bbclass
+++ b/meta/classes-recipe/perl-version.bbclass
@@ -26,7 +26,7 @@ def get_perl_version(d):
             return m.group(1)
     return None
 
-PERLVERSION := "${@get_perl_version(d)}"
+PERLVERSION = "${@get_perl_version(d)}"
 PERLVERSION[vardepvalue] = ""
 
 
@@ -49,7 +49,7 @@ def get_perl_arch(d):
             return m.group(1)
     return None
 
-PERLARCH := "${@get_perl_arch(d)}"
+PERLARCH = "${@get_perl_arch(d)}"
 PERLARCH[vardepvalue] = ""
 
 # Determine the staged arch of perl-native from the perl configuration file
-- 
2.39.2



             reply	other threads:[~2023-04-05  0:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-05  0:38 Patrick Williams [this message]
2023-04-05  8:24 ` [OE-core] [PATCH] perl-version: make PERL* assignments non-immediate Richard Purdie
2023-04-05 12:07   ` Patrick Williams
2023-04-05 22:21     ` Richard Purdie
2023-04-28 16:07 ` [PATCH] perl-version: remove PERL* assignments Patrick Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230405003850.384813-1-patrick@stwcx.xyz \
    --to=patrick@stwcx.xyz \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox