From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72741C7EE23 for ; Tue, 30 May 2023 19:13:48 +0000 (UTC) Received: from mailout4.zoneedit.com (mailout4.zoneedit.com [64.68.198.64]) by mx.groups.io with SMTP id smtpd.web11.3066.1685474024060821615 for ; Tue, 30 May 2023 12:13:45 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: denix.org, ip: 64.68.198.64, mailfrom: denis@denix.org) Received: from localhost (localhost [127.0.0.1]) by mailout4.zoneedit.com (Postfix) with ESMTP id ECF9240C2B; Tue, 30 May 2023 19:13:42 +0000 (UTC) Received: from mailout4.zoneedit.com ([127.0.0.1]) by localhost (zmo14-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id czsFaTeoEfgp; Tue, 30 May 2023 19:13:42 +0000 (UTC) Received: from mail.denix.org (pool-100-15-88-116.washdc.fios.verizon.net [100.15.88.116]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mailout4.zoneedit.com (Postfix) with ESMTPSA id CDA1340C06; Tue, 30 May 2023 19:13:41 +0000 (UTC) Received: by mail.denix.org (Postfix, from userid 1000) id 1C26816392C; Tue, 30 May 2023 15:12:55 -0400 (EDT) Date: Tue, 30 May 2023 15:12:55 -0400 From: Denys Dmytriyenko To: Richard Purdie Cc: openembedded-core@lists.openembedded.org Subject: Re: [OE-core] [PATCH] u-boot: do_compile depends on the value of UBOOT_LOCALVERSION Message-ID: <20230530191255.GH9226@denix.org> References: <20230528171515.832179-1-denis@denix.org> <5e1bf6762dd751f6bf5c5e2463fb91da34efe563.camel@linuxfoundation.org> <20230529160619.GG9226@denix.org> <2e7a44299b2b66447024bd615cdaa938fc3d29c3.camel@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2e7a44299b2b66447024bd615cdaa938fc3d29c3.camel@linuxfoundation.org> User-Agent: Mutt/1.5.20 (2009-06-14) List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Tue, 30 May 2023 19:13:48 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/181944 On Tue, May 30, 2023 at 03:47:07PM +0100, Richard Purdie wrote: > On Mon, 2023-05-29 at 12:06 -0400, Denys Dmytriyenko wrote: > > On Mon, May 29, 2023 at 01:41:00PM +0100, Richard Purdie wrote: > > > On Sun, 2023-05-28 at 17:15 +0000, Denys Dmytriyenko wrote: > > > > UBOOT_LOCALVERSION is often used to pass SCM commit SHA to the code > > > > via populating .scmversion file at the start of do_compile(). Let's > > > > explicitly mark do_compile() as depending on the the value of this > > > > variable to avoid errors like this: > > > > > > > > $ echo 'UBOOT_LOCALVERSION = "${SRCPV}"' >> conf/local.conf > > > > $ bitbake u-boot > > > > ^^^^^^^^ > > > > > > > > Loading cache: 100% > > > > Loaded 0 entries from dependency cache. > > > > WARNING: /OE/poky-master/meta/recipes-bsp/u-boot/u-boot_2023.04.bb: Exception during build_dependencies for do_compile > > > > WARNING: /OE/poky-master/meta/recipes-bsp/u-boot/u-boot_2023.04.bb: Error during finalise of /OE/poky-master/meta/recipes-bsp/u-boot/u-boot_2023.04.bb > > > > ERROR: ExpansionError during parsing /OE/poky-master/meta/recipes-bsp/u-boot/u-boot_2023.04.bb > > > > Traceback (most recent call last): > > > > File "Var ", line 1, in > > > > File "/OE/poky-master/bitbake/lib/bb/fetch2/__init__.py", line 784, in get_srcrev(d=, method_name='sortable_revision'): > > > > if not scms: > > > > > raise FetchError("SRCREV was used yet no valid SCM was found in SRC_URI") > > > > > > > > bb.data_smart.ExpansionError: Failure expanding variable SRCPV, expression was ${@bb.fetch2.get_srcrev(d)} which triggered exception FetchError: Fetcher failure: SRCREV was used yet no valid SCM was found in SRC_URI > > > > The variable dependency chain for the failure is: SRCPV -> UBOOT_LOCALVERSION -> do_compile > > > > > > > > ERROR: Parsing halted due to errors, see error messages above > > > > > > > > Signed-off-by: Denys Dmytriyenko > > > > --- > > > > meta/recipes-bsp/u-boot/u-boot.inc | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/meta/recipes-bsp/u-boot/u-boot.inc b/meta/recipes-bsp/u-boot/u-boot.inc > > > > index b3482dcef3..ec8108f5c9 100644 > > > > --- a/meta/recipes-bsp/u-boot/u-boot.inc > > > > +++ b/meta/recipes-bsp/u-boot/u-boot.inc > > > > @@ -23,6 +23,7 @@ PACKAGECONFIG[openssl] = ",,openssl-native" > > > > # u-boot build system and appended to the u-boot version. If the .scmversion > > > > # file already exists it will not be overwritten. > > > > UBOOT_LOCALVERSION ?= "" > > > > +do_compile[vardepvalue] = "${UBOOT_LOCALVERSION}" > > > > > > > > require u-boot-configure.inc > > > > > > > > > > How would I reproduce this? > > > > The instructions are in the description above. > > Sorry, I'd assumed you'd need a specific target MACHINE so I somehow > didn't think they were complete. No, any qemu target should do. > > > The fix looks a bit like a workaround and I'd like to understand what > > > is really going on here. > > > > This started happening recently after your change that empties SRC_URI for > > code parser cache handling in BB_HASH_CODEPARSER_VALS, as reported here: > > > > https://lists.openembedded.org/g/openembedded-core/message/181726 > > It would be useful if the commit message had mentioned that! > > I suspect the correct fix is to add SRCPV=xxx to > BB_HASH_CODEPARSER_VALS > > Could you see if that works instead? Yes, it works. Do you need a patch? -- Denys