Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: peter.marko@siemens.com
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core][PATCH] gcsections: apply section removal also in C++, not only in C
Date: Thu, 29 Jun 2023 15:32:48 +0200	[thread overview]
Message-ID: <202306291332488ed625f8@mail.local> (raw)
In-Reply-To: <20230629122808.730507-1-peter.marko@siemens.com>

Hello Peter,

I have collected it but this patch should have gone to the poky mailing
list as this is for meta-yocto.

On 29/06/2023 14:28:08+0200, Peter Marko via lists.openembedded.org wrote:
> From: Peter Marko <peter.marko@siemens.com>
> 
> Currently only CFLAGS contains sections optimizations.
> This is used during C compilation.
> C++ compilation uses CXXFLAGS instead.
> 
> I did not introduce CXXFLAGS_SECTION_REMOVAL because the options
> are identical in C and C++, while adding it would add whole lot
> of additional useless lines of code to maintain.
> 
> Signed-off-by: Peter Marko <peter.marko@siemens.com>
> ---
>  meta-poky/conf/distro/include/gcsections.inc | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/meta-poky/conf/distro/include/gcsections.inc b/meta-poky/conf/distro/include/gcsections.inc
> index a1f8651ae9..0e7bd2efff 100644
> --- a/meta-poky/conf/distro/include/gcsections.inc
> +++ b/meta-poky/conf/distro/include/gcsections.inc
> @@ -27,8 +27,10 @@ LDFLAGS_SECTION_REMOVAL:pn-nativesdk-mingw-w64-winpthreads = ""
>  
>  # set default for target
>  CFLAGS:append:class-target = " ${CFLAGS_SECTION_REMOVAL}"
> +CXXFLAGS:append:class-target = " ${CFLAGS_SECTION_REMOVAL}"
>  LDFLAGS:append:class-target = " ${LDFLAGS_SECTION_REMOVAL}"
>  
>  # set default for nativesdk
>  CFLAGS:append:class-nativesdk = " ${CFLAGS_SECTION_REMOVAL}"
> +CXXFLAGS:append:class-nativesdk = " ${CFLAGS_SECTION_REMOVAL}"
>  LDFLAGS:append:class-nativesdk = " ${LDFLAGS_SECTION_REMOVAL}"
> -- 
> 2.30.2
> 

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#183621): https://lists.openembedded.org/g/openembedded-core/message/183621
> Mute This Topic: https://lists.openembedded.org/mt/99849581/3617179
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alexandre.belloni@bootlin.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 


-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


      reply	other threads:[~2023-06-29 13:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-29 12:28 [OE-core][PATCH] gcsections: apply section removal also in C++, not only in C Peter Marko
2023-06-29 13:32 ` Alexandre Belloni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202306291332488ed625f8@mail.local \
    --to=alexandre.belloni@bootlin.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=peter.marko@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox