Re: [OE-core] [PATCH v4 0/5] Add bblock helper scripts

Julien Stephan
2023-08-03T07:19:36Z

Le jeu. 3 août 2023 à 04:57, Chen, Qi <Qi.Chen@windriver.com> a écrit :
>
> When ' include conf/bblock.conf' line can be more flexibly added to/removed from local.conf, is there some specific reason why we should put it in bitbake.conf by default?
>
> Regards,
> Qi
>

Hi Qi,

This was a request from Richard on the first submission [1] :

> To simplify things, I think it would be reasonable to add a bblock.inc
> file unconditionally in our core configuration so that it is always
> included if present, just to make the tool easier since I think this
> will be a common use.

Cheers
Julien

[1): https://lists.openembedded.org/g/openembedded-core/message/184586

> -----Original Message-----
> From: openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org> On Behalf Of Julien Stephan
> Sent: Wednesday, August 2, 2023 10:24 PM
> To: openembedded-core@lists.openembedded.org
> Cc: Julien Stephan <jstephan@baylibre.com>
> Subject: [OE-core] [PATCH v4 0/5] Add bblock helper scripts
>
> Hi all,
>
> This is v4 for bblock script.
>
> Improvement from v3:
> * Add self test
> * Add a new "info" level for SIGGEN_LOCKEDSIGS_TASKSIG_CHECK: this allows to
> display a Note when recipe contains locked task(s)
>
> Limitations:
> * Silently does nothing if given task doesn't exist
> * Silently does nothing when resetting a recipe that doesn't exist
>
> Improvement from v2:
> * Add a function in bb.cooker to compute task signatures
> * Replace the findSigInfo function by the new created one. This has the
> following advantages:
> * findSigInfo needs the task to be already built to get the siginfo
> file, meaning we cannot lock a recipe on a fresh build
> * we can now generate the signatures for all available task of a given
> recipe
> * Check if a given task is already locked. If so, don't duplicate
> entry in bblock.conf
>
> Limitations:
> * Needs to taint tasks that are locked, to display a warning
> * I may be still missing some checks on user input
> * Silently does nothing if given task doesn't exist
> * Silently does nothing when resetting a recipe that doesn't exist
>
> I did some tests using qemux86-64 and qemuarm but I may be missing some corner cases.
>
> Improvement from V1:
> * Signatures are now package architecture specific meaning that if you
> switch MACHINE, the lock sig will not be taken into account
> * I added the -r option to unlock recipes
> * I added a -d option to display the current bblock.conf
> * Added an include directive for conf/bblock.conf inside bitbake.conf
> * Added -t option to specify the tasks to lock/unlock
>
> Limitations:
> * I may be still missing some checks on user input
> * I need to find a way to get the list of tasks ( by default still lock
> only the do_compile for now, unless -t is specified)
> * Do not check if a particular recipe/task is already locked when trying
> to add lock. So entries may appear multiple times
> * We still need the signature of the tasks to be already computed before
> locking. Need to find a way to generate it if missing
>
> V3: https://lists.openembedded.org/g/openembedded-core/message/184932
> V2: https://lists.openembedded.org/g/openembedded-core/message/184697
> V1: https://lists.openembedded.org/g/openembedded-core/message/184584
>
> My branch is available here [1]
>
> Cheers
> Julien
>
> [1]: https://git.yoctoproject.org/poky-contrib/commit/?h=jstephan/bblock
> Julien Stephan (5):
> bitbake.conf: include bblock.conf
> bitbake: cooker: add a new function to retrieve task signatures
> sstatesig: add a new info level for SIGGEN_LOCKEDSIGS_TASKSIG_CHECK
> scripts/bblock: add a script to lock/unlock recipes
> oeqa/selftest/bblock: add self test for bblock tool
>
> bitbake/lib/bb/command.py | 6 +
> bitbake/lib/bb/cooker.py | 16 +++
> bitbake/lib/bb/event.py | 8 ++
> meta/conf/bitbake.conf | 1 +
> meta/lib/oe/sstatesig.py | 13 +-
> meta/lib/oeqa/selftest/cases/bblock.py | 146 ++++++++++++++++++++
> scripts/bblock | 182 +++++++++++++++++++++++++
> 7 files changed, 371 insertions(+), 1 deletion(-) create mode 100644 meta/lib/oeqa/selftest/cases/bblock.py
> create mode 100755 scripts/bblock
>
> --
> 2.41.0