Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: charles-antoine.couret@mind.be
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH 0/5 v3] image_types: use IMAGE_FILE_MAXSIZE variable to create fixed partition size
Date: Sun, 5 Nov 2023 01:26:55 +0100	[thread overview]
Message-ID: <202311050026551c348656@mail.local> (raw)
In-Reply-To: <20231101231058.86928-1-charles-antoine.couret@mind.be>

Hello,

The tests fail on the ubuntu and debian workers but seemed to pass just
fine on fedora:

https://autobuilder.yoctoproject.org/typhoon/#/builders/80/builds/5941/steps/14/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/87/builds/6008/steps/14/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/127/builds/2369/steps/15/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/87/builds/6010/steps/14/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/80/builds/5943/steps/14/logs/stdio

I'm not sure the login timeout is relevant.

Also, can you please fix your git configuration:
https://docs.yoctoproject.org/dev/contributor-guide/submit-changes.html#fixing-your-from-identity

On 02/11/2023 00:10:49+0100, Charles-Antoine Couret via lists.openembedded.org wrote:
> Details are described in the first patch.
> 
> Difference from v2:
> 
> * Added working and failing tests in meta/lib/oeqa/selftest/cases/imagefeatures.py
> * Split commit to send documentation to right mailing list
> 
> Difference from v1:
> 
> * Added documentation for IMAGE_FILE_MAXSIZE variable
> * Added Python function to get the value of this variable from shell functions
> otherwise parsing issue can happen
> * Added an additional task to check the final result which works for all filesystems
> and not only those created with dd command.
> 
> Charles-Antoine Couret (6):
>   image_types: add python function to get the IMAGE_FILE_MAXSIZE:fstype
>     value
>   image_types: use IMAGE_FILE_MAXSIZE variable for ext2/3/4 image types
>   image_types: use IMAGE_FILE_MAXSIZE variable for btrfs image types
>   image_types: use IMAGE_FILE_MAXSIZE variable for f2fs image types
>   image: add check_image_max_size as post function to check file size
>     against IMAGE_FILE_MAXSIZE
>   ref-manual: document IMAGE_FILE_MAXSIZE variable
> 
>  documentation/ref-manual/variables.rst        | 14 +++++
>  meta/classes-recipe/image.bbclass             | 30 +++++++++++
>  meta/classes-recipe/image_types.bbclass       | 43 ++++++++++++---
>  meta/lib/oeqa/selftest/cases/imagefeatures.py | 52 +++++++++++++++++++
>  4 files changed, 131 insertions(+), 8 deletions(-)
> 
> -- 
> 2.41.0
> 

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#190048): https://lists.openembedded.org/g/openembedded-core/message/190048
> Mute This Topic: https://lists.openembedded.org/mt/102331599/3617179
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alexandre.belloni@bootlin.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 


-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


      parent reply	other threads:[~2023-11-05  0:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-01 23:10 [PATCH 0/5 v3] image_types: use IMAGE_FILE_MAXSIZE variable to create fixed partition size Charles-Antoine Couret
2023-11-01 23:10 ` [PATCH 1/5 v3] image_types: add python function to get the IMAGE_FILE_MAXSIZE:fstype value Charles-Antoine Couret
2023-11-01 23:10 ` [PATCH 2/5 v3] image_types: use IMAGE_FILE_MAXSIZE variable for ext2/3/4 image types Charles-Antoine Couret
2023-11-01 23:10 ` [PATCH 3/5 v3] image_types: use IMAGE_FILE_MAXSIZE variable for btrfs " Charles-Antoine Couret
2023-11-01 23:10 ` [PATCH 4/5 v3] image_types: use IMAGE_FILE_MAXSIZE variable for f2fs " Charles-Antoine Couret
2023-11-01 23:10 ` [PATCH 5/5 v3] image: add check_image_max_size as post function to check file size against IMAGE_FILE_MAXSIZE Charles-Antoine Couret
2023-11-05  0:26 ` Alexandre Belloni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202311050026551c348656@mail.local \
    --to=alexandre.belloni@bootlin.com \
    --cc=charles-antoine.couret@mind.be \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox