From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Julien Stephan <jstephan@baylibre.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [RESEND][PATCH 1/7] bitbake: utils: remove spaces on empty lines
Date: Tue, 5 Dec 2023 16:45:19 +0100 [thread overview]
Message-ID: <20231205154519437ea7da@mail.local> (raw)
In-Reply-To: <CAEHHSvb2aKwWmS50G4QZ57oaBJmdkHME01ju4Wa-Nuo+Unnz0A@mail.gmail.com>
On 05/12/2023 15:57:58+0100, Julien Stephan wrote:
> Le mar. 5 d�c. 2023 � 08:50, Alexandre Belloni
> <alexandre.belloni@bootlin.com> a �crit :
> >
> > Please do not send bitbake patches in the same series as oe-core patches
> > if there is no dependency. Those patches are applied on different
> > repositories.
>
> Hi Alexandre,
>
> Noted! Do you want me to resend the series without the bitbake patch?
No but didn't take the bitbake patch because it doesn't do what the
commit message says. (i.e. it touches non empty lines)
>
> Cheers
> Julien
> >
> > On 04/12/2023 16:59:28+0100, Julien Stephan wrote:
> > > Signed-off-by: Julien Stephan <jstephan@baylibre.com>
> > > ---
> > > bitbake/lib/bb/utils.py | 16 ++++++++--------
> > > 1 file changed, 8 insertions(+), 8 deletions(-)
> > >
> > > diff --git a/bitbake/lib/bb/utils.py b/bitbake/lib/bb/utils.py
> > > index b401fa5ec7a..61ffad92ce3 100644
> > > --- a/bitbake/lib/bb/utils.py
> > > +++ b/bitbake/lib/bb/utils.py
> > > @@ -50,7 +50,7 @@ def clean_context():
> > >
> > > def get_context():
> > > return _context
> > > -
> > > +
> > >
> > > def set_context(ctx):
> > > _context = ctx
> > > @@ -212,8 +212,8 @@ def explode_dep_versions2(s, *, sort=True):
> > > inversion = True
> > > # This list is based on behavior and supported comparisons from deb, opkg and rpm.
> > > #
> > > - # Even though =<, <<, ==, !=, =>, and >> may not be supported,
> > > - # we list each possibly valid item.
> > > + # Even though =<, <<, ==, !=, =>, and >> may not be supported,
> > > + # we list each possibly valid item.
> > > # The build system is responsible for validation of what it supports.
> > > if i.startswith(('<=', '=<', '<<', '==', '!=', '>=', '=>', '>>')):
> > > lastcmp = i[0:2]
> > > @@ -347,7 +347,7 @@ def _print_exception(t, value, tb, realfile, text, context):
> > > exception = traceback.format_exception_only(t, value)
> > > error.append('Error executing a python function in %s:\n' % realfile)
> > >
> > > - # Strip 'us' from the stack (better_exec call) unless that was where the
> > > + # Strip 'us' from the stack (better_exec call) unless that was where the
> > > # error came from
> > > if tb.tb_next is not None:
> > > tb = tb.tb_next
> > > @@ -746,9 +746,9 @@ def prunedir(topdir, ionice=False):
> > > # but thats possibly insane and suffixes is probably going to be small
> > > #
> > > def prune_suffix(var, suffixes, d):
> > > - """
> > > + """
> > > See if var ends with any of the suffixes listed and
> > > - remove it if found
> > > + remove it if found
> > > """
> > > for suffix in suffixes:
> > > if suffix and var.endswith(suffix):
> > > @@ -1001,9 +1001,9 @@ def umask(new_mask):
> > > os.umask(current_mask)
> > >
> > > def to_boolean(string, default=None):
> > > - """
> > > + """
> > > Check input string and return boolean value True/False/None
> > > - depending upon the checks
> > > + depending upon the checks
> > > """
> > > if not string:
> > > return default
> > > --
> > > 2.42.0
> > >
> >
> > >
> > > -=-=-=-=-=-=-=-=-=-=-=-
> > > Links: You receive all messages sent to this group.
> > > View/Reply Online (#191754): https://lists.openembedded.org/g/openembedded-core/message/191754
> > > Mute This Topic: https://lists.openembedded.org/mt/102972946/3617179
> > > Group Owner: openembedded-core+owner@lists.openembedded.org
> > > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alexandre.belloni@bootlin.com]
> > > -=-=-=-=-=-=-=-=-=-=-=-
> > >
> >
> >
> > --
> > Alexandre Belloni, co-owner and COO, Bootlin
> > Embedded Linux and Kernel engineering
> > https://bootlin.com
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2023-12-05 15:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 15:59 [RESEND][PATCH 0/7] Devtool/Recipetool: adding pypi support Julien Stephan
2023-12-04 15:59 ` [RESEND][PATCH 1/7] bitbake: utils: remove spaces on empty lines Julien Stephan
2023-12-05 7:50 ` [OE-core] " Alexandre Belloni
2023-12-05 14:57 ` Julien Stephan
2023-12-05 15:45 ` Alexandre Belloni [this message]
2023-12-05 16:27 ` Julien Stephan
[not found] ` <179DFC50B5886FE5.18076@lists.openembedded.org>
2023-12-06 8:24 ` Julien Stephan
2023-12-04 15:59 ` [RESEND][PATCH 2/7] recipetool: create_buildsys_python.py: initialize metadata Julien Stephan
2023-12-04 15:59 ` [RESEND][PATCH 3/7] recipetool: create: add trailing newlines Julien Stephan
2023-12-04 15:59 ` [RESEND][PATCH 4/7] recipetool: create: add new optional process_url callback for plugins Julien Stephan
2023-12-04 15:59 ` [RESEND][PATCH 5/7] recipetool: create_buildsys_python: add pypi support Julien Stephan
2023-12-09 1:15 ` [OE-core] " Tim Orling
2023-12-04 15:59 ` [RESEND][PATCH 6/7] oeqa/selftest/recipetool: remove spaces on empty lines Julien Stephan
2023-12-04 15:59 ` [RESEND][PATCH 7/7] oeqa/selftest/recipetool/devtool: add test for pypi class Julien Stephan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231205154519437ea7da@mail.local \
--to=alexandre.belloni@bootlin.com \
--cc=jstephan@baylibre.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox