From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Ross Burton <ross.burton@arm.com>
Cc: openembedded-core@lists.openembedded.org, nd@arm.com
Subject: Re: [OE-core] [PATCH 1/9] nativesdk: ensure features don't get backfilled
Date: Thu, 14 Dec 2023 08:49:32 +0100 [thread overview]
Message-ID: <20231214074932cba7c5f3@mail.local> (raw)
In-Reply-To: <20231212140820.2900963-2-ross.burton@arm.com>
Hello Ross,
Not obvious but this is the cause of:
https://autobuilder.yoctoproject.org/typhoon/#/builders/20/builds/8697
On 12/12/2023 14:08:12+0000, Ross Burton wrote:
> From: Ross Burton <ross.burton@arm.com>
>
> nativesdk aims to run in a slightly different environment than the
> target build, so it unsets MACHINE_FEATURES and lets DISTRO_FEATURES be
> filtered by DISTRO_FEATURES_NATIVESDK (in bitbake.conf).
>
> However, feature backfill happens _after_ these operations:
>
> $ bitbake-getvar -r nativesdk-glib-2.0 MACHINE_FEATURES
> #
> # $MACHINE_FEATURES [5 operations]
> # set /home/ross/Yocto/poky/meta/conf/machine/include/qemu.inc:14
> # "alsa bluetooth usbgadget screen vfat"
> # set /home/ross/Yocto/poky/meta/conf/documentation.conf:284
> # [doc] "Specifies the list of hardware features the MACHINE supports."
> # set? /home/ross/Yocto/poky/meta/conf/bitbake.conf:893
> # ""
> # set /home/ross/Yocto/poky/meta/classes-recipe/nativesdk.bbclass:18
> # ""
> # append utils.py:132 [features_backfill]
> # " rtc qemu-usermode"
> # pre-expansion value:
> # " rtc qemu-usermode"
> MACHINE_FEATURES=" rtc qemu-usermode"
>
> I don't believe this is intentional or desired as the machine features
> are unrelated to the nativesdk environment. Specifically, this means
> that recipes that look for the qemu-usermode machine feature will fail
> in nativesdk as there may not actually be qemu-user support for the
> nativesdk environment.
>
> Signed-off-by: Ross Burton <ross.burton@arm.com>
> ---
> meta/classes-recipe/nativesdk.bbclass | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/meta/classes-recipe/nativesdk.bbclass b/meta/classes-recipe/nativesdk.bbclass
> index 08288fdb733..ccaf411f0d7 100644
> --- a/meta/classes-recipe/nativesdk.bbclass
> +++ b/meta/classes-recipe/nativesdk.bbclass
> @@ -15,7 +15,10 @@ NATIVESDKLIBC ?= "libc-glibc"
> LIBCOVERRIDE = ":${NATIVESDKLIBC}"
> CLASSOVERRIDE = "class-nativesdk"
> MACHINEOVERRIDES = ""
> +
> MACHINE_FEATURES = ""
> +DISTRO_FEATURES_BACKFILL = ""
> +MACHINE_FEATURES_BACKFILL = ""
>
> MULTILIBS = ""
>
> --
> 2.34.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#192193): https://lists.openembedded.org/g/openembedded-core/message/192193
> Mute This Topic: https://lists.openembedded.org/mt/103129922/3617179
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alexandre.belloni@bootlin.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2023-12-14 7:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 14:08 [PATCH 0/9] Let autoreconf run gtkdocize ross.burton
2023-12-12 14:08 ` [PATCH 1/9] nativesdk: ensure features don't get backfilled ross.burton
2023-12-14 7:49 ` Alexandre Belloni [this message]
2023-12-14 13:31 ` [OE-core] " Ross Burton
2023-12-14 13:35 ` Richard Purdie
2023-12-14 13:49 ` Alexander Kanavin
[not found] ` <17A0B6EC18C51F9F.5876@lists.openembedded.org>
2023-12-14 14:14 ` Alexander Kanavin
2023-12-12 14:08 ` [PATCH 2/9] glib-2.0: no need to depend on target gtk-doc ross.burton
2023-12-12 14:08 ` [PATCH 3/9] autotools: append to EXTRA_AUTORECONF ross.burton
2023-12-12 14:08 ` [PATCH 4/9] autotools: don't exclude gtkdocize ross.burton
2023-12-12 14:08 ` [PATCH 5/9] gtk-doc: remove obsolete logic ross.burton
2023-12-12 14:08 ` [PATCH 6/9] gtk-doc: don't use docdir set in environment in gtkdocize ross.burton
2023-12-12 14:08 ` [PATCH 7/9] gtk-doc: don't manually call gtkdocize ross.burton
2023-12-12 14:08 ` [PATCH 8/9] kmod: fix configure with autopoint calling gtkdocize ross.burton
2023-12-12 14:08 ` [PATCH 9/9] util-linux: ensure gtkdocize isn't called ross.burton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231214074932cba7c5f3@mail.local \
--to=alexandre.belloni@bootlin.com \
--cc=nd@arm.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox