[PATCH 1/3] nativesdk-packagegroup-sdk-host: add gprofng package to RDEPENDS

[PATCH 1/3] nativesdk-packagegroup-sdk-host: add gprofng package to RDEPENDS

[Harish.Sadineni]

From: Harish Sadineni <Harish.Sadineni@windriver.com>

In SDK, while running "x86_64-poky-linux-gp-collect-app ./exe" fails to create 'test.1.er' due to missing gprofng configure file in sysconfdir and aborting with below error while generating the profiling data.
- configuration error: can not find libgp-collector.so. run aborted

Signed-off-by: Harish Sadineni <Harish.Sadineni@windriver.com>
---
 .../packagegroups/nativesdk-packagegroup-sdk-host.bb             | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-core/packagegroups/nativesdk-packagegroup-sdk-host.bb b/meta/recipes-core/packagegroups/nativesdk-packagegroup-sdk-host.bb
index c1d3c25060..5374067bab 100644
--- a/meta/recipes-core/packagegroups/nativesdk-packagegroup-sdk-host.bb
+++ b/meta/recipes-core/packagegroups/nativesdk-packagegroup-sdk-host.bb
@@ -30,6 +30,7 @@ RDEPENDS:${PN} = "\
     nativesdk-bison \
     nativesdk-flex \
     nativesdk-perl-module-integer \
+    nativesdk-gprofng \
     "
 
 RDEPENDS:${PN}:darwin = "\
-- 
2.43.0

[PATCH 2/3] autoconf: Add missing perl modules to RDEPENDS

[Harish.Sadineni]

From: Harish Sadineni <Harish.Sadineni@windriver.com>

In SDK, missing perl modules causes 'x86_64-wrlinuxsdk-linux-gp-display-html --help' to abort with below errors..
 - Can't locate bignum.pm in @INC (you may need to install the feature module).
 - Can't locate Math/BigInt.pm in @INC (you may need to install the Math::BigInt module)

Signed-off-by: Harish Sadineni <Harish.Sadineni@windriver.com>
---
 meta/recipes-devtools/autoconf/autoconf_2.72e.bb | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/meta/recipes-devtools/autoconf/autoconf_2.72e.bb b/meta/recipes-devtools/autoconf/autoconf_2.72e.bb
index db374373cf..2a459b7cb6 100644
--- a/meta/recipes-devtools/autoconf/autoconf_2.72e.bb
+++ b/meta/recipes-devtools/autoconf/autoconf_2.72e.bb
@@ -52,6 +52,9 @@ RDEPENDS:${PN} = "m4 gnu-config \
 		  perl-module-thread-queue \
 		  perl-module-threads \
 		  perl-module-feature \
+                  perl-module-bignum \
+                  perl-module-bigint \
+                  perl-module-math-bigint \
 		 "
 RDEPENDS:${PN}:class-native = "m4-native gnu-config-native hostperl-runtime-native"
 
-- 
2.43.0

Re: [OE-core] [PATCH 2/3] autoconf: Add missing perl modules to RDEPENDS

[Richard Purdie]

On Fri, 2024-03-22 at 03:10 -0700, Sadineni, Harish via
lists.openembedded.org wrote:
> From: Harish Sadineni <Harish.Sadineni@windriver.com>
> 
> In SDK, missing perl modules causes 'x86_64-wrlinuxsdk-linux-gp-
> display-html --help' to abort with below errors..
>  - Can't locate bignum.pm in @INC (you may need to install the
> feature module).
>  - Can't locate Math/BigInt.pm in @INC (you may need to install the
> Math::BigInt module)
> 
> Signed-off-by: Harish Sadineni <Harish.Sadineni@windriver.com>
> ---
>  meta/recipes-devtools/autoconf/autoconf_2.72e.bb | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/meta/recipes-devtools/autoconf/autoconf_2.72e.bb
> b/meta/recipes-devtools/autoconf/autoconf_2.72e.bb
> index db374373cf..2a459b7cb6 100644
> --- a/meta/recipes-devtools/autoconf/autoconf_2.72e.bb
> +++ b/meta/recipes-devtools/autoconf/autoconf_2.72e.bb
> @@ -52,6 +52,9 @@ RDEPENDS:${PN} = "m4 gnu-config \
>  		  perl-module-thread-queue \
>  		  perl-module-threads \
>  		  perl-module-feature \
> +                  perl-module-bignum \
> +                  perl-module-bigint \
> +                  perl-module-math-bigint \
>  		 "
>  RDEPENDS:${PN}:class-native = "m4-native gnu-config-native hostperl-
> runtime-native"
>  

Was this dependency missing from autoconf or was it from some tools in
binutils? If the latter, we should be adding the missing dependency to
the specific package.

Cheers,

Richard

Re: [PATCH 2/3] autoconf: Add missing perl modules to RDEPENDS

[Sadineni, Harish]

[-- Attachment #1: Type: text/plain, Size: 89 bytes --]

This dependency is from autoconf itself, not from binutils.

Thanks,
Harish sadineni

[-- Attachment #2: Type: text/html, Size: 120 bytes --]

[PATCH 3/3] binutils: gprofng - change use of bignum to use of bignint

[Harish.Sadineni]

From: Harish Sadineni <Harish.Sadineni@windriver.com>

In SDK, The "x86_64-pokysdk-linux-gp-display-html" fails with below error while genearting profiling html reports from test experiment file (eg., test.1.er)
Error: Undefined subroutine &bigint::hex called at .../sysroots/x86_64-pokysdk-linux/usr/bin/x86_64-pokysdk-linux-gp-display-html line 4059, <MAP_XML> line 1.

Upstream-Status: Backport [https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=3243d790ee32aa8eda69226d81b1e79dbd1dcd87]

Signed-off-by: Harish Sadineni <Harish.Sadineni@windriver.com>
---
 .../recipes-devtools/binutils/binutils-2.42.inc |  1 +
 ...gprofng-change-use-of-bignum-to-bigint.patch | 17 +++++++++++++++++
 2 files changed, 18 insertions(+)
 create mode 100644 meta/recipes-devtools/binutils/binutils/0015-gprofng-change-use-of-bignum-to-bigint.patch

diff --git a/meta/recipes-devtools/binutils/binutils-2.42.inc b/meta/recipes-devtools/binutils/binutils-2.42.inc
index 5fcb4292b3..3b6f47d4ce 100644
--- a/meta/recipes-devtools/binutils/binutils-2.42.inc
+++ b/meta/recipes-devtools/binutils/binutils-2.42.inc
@@ -35,5 +35,6 @@ SRC_URI = "\
      file://0012-Only-generate-an-RPATH-entry-if-LD_RUN_PATH-is-not-e.patch \
      file://0013-Define-alignof-using-_Alignof-when-using-C11-or-newe.patch \
      file://0014-Remove-duplicate-pe-dll.o-entry-deom-targ_extra_ofil.patch \
+     file://0015-gprofng-change-use-of-bignum-to-bigint.patch \
 "
 S  = "${WORKDIR}/git"
diff --git a/meta/recipes-devtools/binutils/binutils/0015-gprofng-change-use-of-bignum-to-bigint.patch b/meta/recipes-devtools/binutils/binutils/0015-gprofng-change-use-of-bignum-to-bigint.patch
new file mode 100644
index 0000000000..0d3d289eba
--- /dev/null
+++ b/meta/recipes-devtools/binutils/binutils/0015-gprofng-change-use-of-bignum-to-bigint.patch
@@ -0,0 +1,17 @@
+Upstream-Status: Backport [https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=3243d790ee32aa8eda69226d81b1e79dbd1dcd87]
+
+Signed-off-by: Harish Sadineni <Harish.Sadineni@windriver.com>
+
+diff --git a/gprofng/gp-display-html/gp-display-html.in b/gprofng/gp-display-html/gp-display-html.in
+index 6f37ca282e7..306c99a0ec3 100644
+--- a/gprofng/gp-display-html/gp-display-html.in
++++ b/gprofng/gp-display-html/gp-display-html.in
+@@ -25,7 +25,7 @@ use warnings;
+ # Disable before release
+ # use Perl::Critic;
+ 
+-use bignum;
++use bigint;
+ use List::Util qw (max);
+ use Cwd qw (abs_path cwd);
+ use File::Basename;
-- 
2.43.0

Re: [OE-core] [PATCH 1/3] nativesdk-packagegroup-sdk-host: add gprofng package to RDEPENDS

[Richard Purdie]

On Fri, 2024-03-22 at 03:10 -0700, Sadineni, Harish via
lists.openembedded.org wrote:
> From: Harish Sadineni <Harish.Sadineni@windriver.com>
> 
> In SDK, while running "x86_64-poky-linux-gp-collect-app ./exe" fails
> to create 'test.1.er' due to missing gprofng configure file in
> sysconfdir and aborting with below error while generating the
> profiling data.
> - configuration error: can not find libgp-collector.so. run aborted
> 
> Signed-off-by: Harish Sadineni <Harish.Sadineni@windriver.com>
> ---
>  .../packagegroups/nativesdk-packagegroup-sdk-host.bb             | 1
> +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta/recipes-core/packagegroups/nativesdk-packagegroup-
> sdk-host.bb b/meta/recipes-core/packagegroups/nativesdk-packagegroup-
> sdk-host.bb
> index c1d3c25060..5374067bab 100644
> --- a/meta/recipes-core/packagegroups/nativesdk-packagegroup-sdk-
> host.bb
> +++ b/meta/recipes-core/packagegroups/nativesdk-packagegroup-sdk-
> host.bb
> @@ -30,6 +30,7 @@ RDEPENDS:${PN} = "\
>      nativesdk-bison \
>      nativesdk-flex \
>      nativesdk-perl-module-integer \
> +    nativesdk-gprofng \
>      "
>  
>  RDEPENDS:${PN}:darwin = "\

Should the package which contains x86_64-poky-linux-gp-collect-app not
be the place where we need to add this dependency?

Cheers,

Richard

Re: [PATCH 1/3] nativesdk-packagegroup-sdk-host: add gprofng package to RDEPENDS

[Sadineni, Harish]

[-- Attachment #1: Type: text/plain, Size: 329 bytes --]

gprofng belongs to binutils module, i tried a build by adding it in binutils-cross-canadian.inc and the build is sucessfully generating gprofng.rc in sysconf directory as expected.
we have sent a v2 patch by adding it in binutils (https://lists.openembedded.org/g/openembedded-core/message/197632).

Thanks,
Harish sadineni

[-- Attachment #2: Type: text/html, Size: 383 bytes --]