From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24DB5C47074 for ; Thu, 4 Jan 2024 09:47:51 +0000 (UTC) Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by mx.groups.io with SMTP id smtpd.web10.50757.1704361669822674851 for ; Thu, 04 Jan 2024 01:47:50 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=KVRtKA4O; spf=pass (domain: bootlin.com, ip: 217.70.183.196, mailfrom: alexandre.belloni@bootlin.com) Received: by mail.gandi.net (Postfix) with ESMTPSA id 8BF16E000D; Thu, 4 Jan 2024 09:47:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1704361668; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yip99UiqMN4AVfPg+rmi95vQ372Vf6xeKPp1syeTKe8=; b=KVRtKA4OcpKw58IElbJQ1KQ1wqxwO56EyVRYe6tlusSA4udTfDPb3SNBK/oyBkDFOs/r2S vQSA4Q1rpPOGxL8sWCHANszET0ZNd5RTPjb3CUYaKQNtK53BNU6MVVCJYA1ePBkig/tU0E NgZ5aLRRMvvkQ474QyPX+J3S4qHVo6/I2ZcbOUmERgU1w+FKuUB/A3VHkJ4u+CXHErwzkS uLfGNaZadnPaGV/QAKbYA/WL+cFBwUROlAtXF/sHz7qBmAs0Q/rucBn/FhbAuhqGC3R4Yp 3+sbMhh4Bwi8cPvnnOYBfoZe73VJFc6rQg3UsdZU/wRx1xx8vc9EDY+UtPH+Bg== Date: Thu, 4 Jan 2024 10:47:47 +0100 From: Alexandre Belloni To: enrico.scholz@sigma-chemnitz.de Cc: openembedded-core@lists.openembedded.org Subject: Re: [OE-core] [PATCH] tcp-wrappers: drop libnsl2 build dependency Message-ID: <20240104094747168bb726@mail.local> References: <20240103115944.446914-1-enrico.scholz@sigma-chemnitz.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240103115944.446914-1-enrico.scholz@sigma-chemnitz.de> X-GND-Sasl: alexandre.belloni@bootlin.com List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Thu, 04 Jan 2024 09:47:51 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/193309 Hello, Your patch has a declared charset of 'y' which is not a thing and git am fails with: error: cannot convert from y to UTF-8 fatal: could not parse patch You got the following prompt: The following files are 8bit, but do not declare a Content-Transfer-Encoding. something.patch Which 8bit encoding should I declare [UTF-8]? At that point, you pressed y but you should simply press enter. Please resend. On 03/01/2024 12:59:44+0100, Enrico Scholz via lists.openembedded.org wrote: > From: Enrico Scholz > > The only libnsl2 function which is used by tcp-wrappers is > 'yp_get_default_domain()'. When USE_GETDOMAIN is set, this is > implemented as a simple wrapper around getdomainname() so that libnsl2 > is not used at all. > > We added a patch which does '#include ' to avoid > implicit forward declaration. By conditionalizing this, the libnsl2 > dependency can be dropped completely. > > Signed-off-by: Enrico Scholz > --- > ...0001-Fix-implicit-function-declaration-warnings.patch | 9 +++++++-- > meta/recipes-extended/tcp-wrappers/tcp-wrappers_7.6.bb | 2 -- > 2 files changed, 7 insertions(+), 4 deletions(-) > > diff --git a/meta/recipes-extended/tcp-wrappers/tcp-wrappers-7.6/0001-Fix-implicit-function-declaration-warnings.patch b/meta/recipes-extended/tcp-wrappers/tcp-wrappers-7.6/0001-Fix-implicit-function-declaration-warnings.patch > index ec793ac8ffed..474703885d9b 100644 > --- a/meta/recipes-extended/tcp-wrappers/tcp-wrappers-7.6/0001-Fix-implicit-function-declaration-warnings.patch > +++ b/meta/recipes-extended/tcp-wrappers/tcp-wrappers-7.6/0001-Fix-implicit-function-declaration-warnings.patch > @@ -20,11 +20,16 @@ diff --git a/hosts_access.c b/hosts_access.c > index 0133e5e..58697ea 100644 > --- a/hosts_access.c > +++ b/hosts_access.c > -@@ -33,6 +33,7 @@ static char sccsid[] = "@(#) hosts_access.c 1.21 97/02/12 02:13:22"; > +@@ -33,6 +33,12 @@ static char sccsid[] = "@(#) hosts_access.c 1.21 97/02/12 02:13:22"; > #endif > #include > #include > -+#include > ++#ifdef USE_GETDOMAIN > ++/* defined in workarounds.c */ > ++extern int yp_get_default_domain(char **ptr); > ++#else > ++# include > ++#endif /* USE_GETDOMAIN */ > #include > #include > #include > diff --git a/meta/recipes-extended/tcp-wrappers/tcp-wrappers_7.6.bb b/meta/recipes-extended/tcp-wrappers/tcp-wrappers_7.6.bb > index c655da1199e7..bcd1d6f7929e 100644 > --- a/meta/recipes-extended/tcp-wrappers/tcp-wrappers_7.6.bb > +++ b/meta/recipes-extended/tcp-wrappers/tcp-wrappers_7.6.bb > @@ -7,8 +7,6 @@ SECTION = "console/network" > LICENSE = "BSD-1-Clause" > LIC_FILES_CHKSUM = "file://DISCLAIMER;md5=071bd69cb78b18888ea5e3da5c3127fa" > > -DEPENDS += "libnsl2" > - > PACKAGES = "${PN}-dbg libwrap libwrap-doc libwrap-dev libwrap-staticdev ${PN} ${PN}-doc" > FILES:libwrap = "${base_libdir}/lib*${SOLIBS}" > FILES:libwrap-doc = "${mandir}/man3 ${mandir}/man5" > -- > 2.43.0 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#193285): https://lists.openembedded.org/g/openembedded-core/message/193285 > Mute This Topic: https://lists.openembedded.org/mt/103500355/3617179 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alexandre.belloni@bootlin.com] > -=-=-=-=-=-=-=-=-=-=-=- > -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com