From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Alexander Kanavin <alex.kanavin@gmail.com>
Cc: openembedded-core@lists.openembedded.org,
Alexander Kanavin <alex@linutronix.de>
Subject: Re: [OE-core] [PATCH 1/4] oeqa/runtime/rpm: raise exception if test rpm file cannot be found
Date: Thu, 18 Jan 2024 23:31:39 +0100 [thread overview]
Message-ID: <2024011822313993eb2a24@mail.local> (raw)
In-Reply-To: <20240118102409.2680941-1-alex@linutronix.de>
Hello,
This fails pkgman-non-rpm:
https://autobuilder.yoctoproject.org/typhoon/#/builders/76/builds/8412
On 18/01/2024 11:24:06+0100, Alexander Kanavin wrote:
> The tests rely on that, and so the discovery shouldn't simply
> fall through.
>
> Signed-off-by: Alexander Kanavin <alex@linutronix.de>
> ---
> meta/lib/oeqa/runtime/cases/rpm.py | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/meta/lib/oeqa/runtime/cases/rpm.py b/meta/lib/oeqa/runtime/cases/rpm.py
> index a4ba4e67698..bd9050a81b2 100644
> --- a/meta/lib/oeqa/runtime/cases/rpm.py
> +++ b/meta/lib/oeqa/runtime/cases/rpm.py
> @@ -88,9 +88,12 @@ class RpmInstallRemoveTest(OERuntimeTestCase):
> # and it will always be built for standard targets
> rpm_doc = 'base-passwd-doc-*.%s.rpm' % pkgarch
> if not os.path.exists(rpmdir):
> - return
> + raise Exception("Rpm directory {} does not exist".format(cls.tc.td['DEPLOY_DIR']))
> for f in fnmatch.filter(os.listdir(rpmdir), rpm_doc):
> cls.test_file = os.path.join(rpmdir, f)
> + break
> + else:
> + raise Exception("Couldn't find the test rpm file {} in {}".format(rpm_doc, rpmdir))
> cls.dst = '/tmp/base-passwd-doc.rpm'
>
> @OETestDepends(['rpm.RpmBasicTest.test_rpm_query'])
> --
> 2.39.2
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#193969): https://lists.openembedded.org/g/openembedded-core/message/193969
> Mute This Topic: https://lists.openembedded.org/mt/103805481/3617179
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alexandre.belloni@bootlin.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2024-01-18 22:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 10:24 [PATCH 1/4] oeqa/runtime/rpm: raise exception if test rpm file cannot be found Alexander Kanavin
2024-01-18 10:24 ` [PATCH 2/4] classes/package_rpm: write file permissions and ownership explicitly into .spec Alexander Kanavin
2024-01-19 10:01 ` [OE-core] " Alexandre Belloni
2024-01-18 10:24 ` [PATCH 3/4] classes/package_rpm: use weak user/group dependencies Alexander Kanavin
2024-01-18 10:24 ` [PATCH 4/4] rpm: update 4.18.1 -> 4.19.1 Alexander Kanavin
2024-01-19 10:02 ` [OE-core] " Alexandre Belloni
2024-01-18 22:31 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024011822313993eb2a24@mail.local \
--to=alexandre.belloni@bootlin.com \
--cc=alex.kanavin@gmail.com \
--cc=alex@linutronix.de \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox