From: Julien Stephan <jstephan@baylibre.com>
To: openembedded-core@lists.openembedded.org
Cc: Julien Stephan <jstephan@baylibre.com>
Subject: [PATCH v3 0/3] devtool: modify: add support for multiple source
Date: Tue, 23 Jan 2024 15:06:48 +0100 [thread overview]
Message-ID: <20240123140651.930307-1-jstephan@baylibre.com> (raw)
Hello all,
As we discussed in #15162, I tried to implement a devtool unpack tracer.
I did manage to get a list of files unpacked after do_unpack and
manually copy them into WORKDIR but:
- unpack tracer just tells us the url and the unpack dir, but does not
directly give the unpacked files. Of course we can get the list by
looking at files in the temporary workdir directory at the beginning
and the end of unpack, but I guess we can also do that without the
unpack tracer mechanism
- the issue we are trying to fix here, is to get the secondary sources.
We can obviously use the unpack tracer for that, but the main source,
and local files (file://) are already correctly handled, so we would
end up handling different parts of SRC_URI in different location..
IMHO the unpack tracer should handle all the src_uri entries itself
but it means a more global code refactor.
Moreover, it turns out that the issue we are trying to solve was already known
and externalsrc class can handle secondary sources. The fix was
introduced with:
da1bcf08089 - devtool: add support for multiple git url inside a cargo based recipe <Frederic Martinsons>
We can modify the problematic recipes by adding "type=git-dependency"
on the src_uri entries of the dependencies (secondary sources).
So, I am sending a patch to automatically add the "type=git-dependency"
on secondary sources when a recipe is under devtool control by modifying
the SRC_URI inside the append recipe (in build/workspace/appends/)
Doing that, I tested my work with the bzip2 recipe and found another
bug on do_populate_lic dependency. I added a patch to this series
because otherwise the selftest will not work, but it can be applied
separately.
Cheers
Julien
Julien Stephan (3):
externalsrc: fix task dependency for do_populate_lic
devtool: modify: add support for multiple source in SRC_URI
oeqa/selftest/devtool: add test for recipes with multiple sources in
SRC_URI
meta/classes/externalsrc.bbclass | 1 +
meta/lib/oeqa/selftest/cases/devtool.py | 26 +++++++++++++++++++++++++
scripts/lib/devtool/standard.py | 20 +++++++++++++++++++
3 files changed, 47 insertions(+)
--
2.43.0
next reply other threads:[~2024-01-23 14:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 14:06 Julien Stephan [this message]
2024-01-23 14:06 ` [PATCH v3 1/3] externalsrc: fix task dependency for do_populate_lic Julien Stephan
2024-01-23 14:06 ` [PATCH v3 2/3] devtool: modify: add support for multiple source in SRC_URI Julien Stephan
2024-01-23 14:06 ` [PATCH v3 3/3] oeqa/selftest/devtool: add test for recipes with multiple sources " Julien Stephan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240123140651.930307-1-jstephan@baylibre.com \
--to=jstephan@baylibre.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox