Re: [OE-core] [PATCH] usrmerge: add the distro feature to nativesdk builds when added to target and enable symlink creation for both

Richard Purdie
2024-02-06T10:27:54Z

On Thu, 2024-02-01 at 02:56 +0000, Maanya Goenka wrote:
> From: Maanya Goenka <maanyagoenka@microsoft.com>
>
> Add usrmerge to DISTRO_FEATURES_FILTER_NATIVESDK (and DISTRO_FEATURES_FILTER_NATIVE for consistency),
> since we have come across cases where the distro feature would be required by both contexts.
> As a supplement to this change, when creating the merged usr symlinks at the do_populate_sdk stage,
> these need to be created for both the target and native sysroots within the SDK.
>
> Signed-off-by: Maanya Goenka <maanyagoenka@microsoft.com>
> Signed-off-by : Alejandro Hernandez Samaniego <alhe@linux.microsoft.com>
> ---
> meta/classes-recipe/image.bbclass | 2 ++
> meta/conf/bitbake.conf | 4 ++--
> 2 files changed, 4 insertions(+), 2 deletions(-)

This doesn't quite follow. "target", "nativesdk" and "native" are all
different separate filesystems and not connected. Yes, you can use
usrmerge on some (or all?) of them but you don't have to have them
match.

Forcing them to match is likely just working around an underlying issue
which needs to be fixed.

What were the real failures?

For example, this would stop native or nativesdk sstate being reused
between differently configured builds when it could be.

Cheers,

Richard