From: Peter Kjellerstedt <pkj@axis.com>
To: <openembedded-core@lists.openembedded.org>
Subject: [PATCH] devtool: modify: Correct appending of type=git-dependency to URIs
Date: Thu, 15 Feb 2024 23:12:50 +0100 [thread overview]
Message-ID: <20240215221250.1161135-1-pkj@axis.com> (raw)
A missing space when using :append would lead to run-on URIs if there
was no whitespace at the end of the original SRC_URI.
Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
---
scripts/lib/devtool/standard.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/lib/devtool/standard.py b/scripts/lib/devtool/standard.py
index 8fb4b934d4..0243e3bc75 100644
--- a/scripts/lib/devtool/standard.py
+++ b/scripts/lib/devtool/standard.py
@@ -966,7 +966,7 @@ def modify(args, config, basepath, workspace):
# Assume first entry is main source extracted in ${S} so skip it
src_uri = src_uri[1::]
- #Add "type=git-dependency" to all non local sources
+ # Add "type=git-dependency" to all non local sources
for url in src_uri:
if not url.startswith('file://') and not 'type=' in url:
src_uri_remove.append(url)
@@ -974,7 +974,7 @@ def modify(args, config, basepath, workspace):
if src_uri_remove:
f.write('SRC_URI:remove = "%s"\n' % ' '.join(src_uri_remove))
- f.write('SRC_URI:append = "%s"\n\n' % ' '.join(src_uri_append))
+ f.write('SRC_URI:append = " %s"\n\n' % ' '.join(src_uri_append))
f.write('FILESEXTRAPATHS:prepend := "${THISDIR}/${PN}:"\n')
# Local files can be modified/tracked in separate subdir under srctree
reply other threads:[~2024-02-15 22:13 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240215221250.1161135-1-pkj@axis.com \
--to=pkj@axis.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox