Re: [OE-core] [PATCH] u-boot: Fix potential index error issues in do_deploy with multiple u-boot configurations

[Alexandre Belloni <alexandre.belloni@bootlin.com>]

Hello,

On 02/07/2024 01:16:35-0700, Florian Amstutz wrote:
> If i or j have not been unset in do_deploy:prepend functions, images are not correctly
> copied to DEPLOYDIR.
> 
> Signed-off-by: Florian Amstutz <florian.amstutz@scs.ch>
> ---
> meta/recipes-bsp/u-boot/u-boot.inc | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/meta/recipes-bsp/u-boot/u-boot.inc b/meta/recipes-bsp/u-boot/u-boot.inc
> index 54ea2e9e50..70fb192d6e 100644
> --- a/meta/recipes-bsp/u-boot/u-boot.inc
> +++ b/meta/recipes-bsp/u-boot/u-boot.inc
> @@ -209,6 +209,7 @@ RDEPENDS:${PN} += "${PN}-env"
> do_deploy () {

Whitespaces are missing in your patch, so it doesn't apply (this line
should begin with a space).

> if [ -n "${UBOOT_CONFIG}" ]
> then
> + � � � �unset i j


I feel this should be fixed in your do_deploy:prepend or we are going to
end up with thousands of patches unsetting variables that are not set
just in case a :prepend sets them.

> for config in ${UBOOT_MACHINE}; do
> i=$(expr $i + 1);
> for type in ${UBOOT_CONFIG}; do
> --
> 2.34.1

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#201415): https://lists.openembedded.org/g/openembedded-core/message/201415
> Mute This Topic: https://lists.openembedded.org/mt/106996344/3617179
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alexandre.belloni@bootlin.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 


-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com