public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Denys Dmytriyenko <denis@denix.org>
To: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] llvm: extend llvm-config reproducivility fix to all classes
Date: Tue, 16 Jul 2024 18:11:35 -0400	[thread overview]
Message-ID: <20240716221135.GC17572@denix.org> (raw)
In-Reply-To: <725daf1938215f5228a29b272f446ad37d96d58e.camel@linuxfoundation.org>

On Tue, Jul 16, 2024 at 08:12:25AM +0100, Richard Purdie wrote:
> On Mon, 2024-07-15 at 21:36 -0400, Denys Dmytriyenko via
> lists.openembedded.org wrote:
> > It's not limited to "target", but also happens to e.g. nativesdk:
> > 
> > ERROR: nativesdk-llvm-18.1.8-r0 do_package_qa: QA Issue: File
> > /usr/local/oe-sdk-hardcoded-buildpath/sysroots/x86_64-pokysdk-
> > linux/usr/bin/llvm-config in package nativesdk-llvm contains
> > reference to TMPDIR [buildpaths]
> > 
> > Signed-off-by: Denys Dmytriyenko <denis@denix.org>
> > ---
> >  meta/recipes-devtools/llvm/llvm_18.1.8.bb | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/meta/recipes-devtools/llvm/llvm_18.1.8.bb
> > b/meta/recipes-devtools/llvm/llvm_18.1.8.bb
> > index 8dad952923..6afca9c7d7 100644
> > --- a/meta/recipes-devtools/llvm/llvm_18.1.8.bb
> > +++ b/meta/recipes-devtools/llvm/llvm_18.1.8.bb
> > @@ -95,7 +95,7 @@ EXTRA_OECMAKE:append:class-nativesdk = "\
> >                   "
> >  
> >  # patch out build host paths for reproducibility
> > -do_compile:prepend:class-target() {
> > +do_compile:prepend() {
> >          sed -i -e "s,${WORKDIR},,g" ${B}/tools/llvm-
> > config/BuildVariables.inc
> >  }
> >  
> 
> 
> Do we need those buildpaths in llvm-native?

I'm not really sure, but I can spin up a v2.

-- 
Denys


  reply	other threads:[~2024-07-16 22:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-16  1:36 [PATCH] llvm: extend llvm-config reproducivility fix to all classes Denys Dmytriyenko
2024-07-16  7:12 ` [OE-core] " Richard Purdie
2024-07-16 22:11   ` Denys Dmytriyenko [this message]
2024-07-16 22:20     ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240716221135.GC17572@denix.org \
    --to=denis@denix.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=richard.purdie@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox