public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: <mark.jonas@de.bosch.com>
To: <openembedded-core@lists.openembedded.org>
Cc: <bluca@debian.org>, <luca.boccassi@microsoft.com>,
	<matt.hoosier@garmin.com>, <richard.purdie@linuxfoundation.org>,
	<mark.jonas@de.bosch.com>,
	Ricardo Simoes <ricardo.simoes@pt.bosch.com>
Subject: [PATCH 0/2] volatile-binds: Mitigate workdir cleanup issues
Date: Thu, 18 Jul 2024 08:46:32 +0200	[thread overview]
Message-ID: <20240718064634.7276-1-mark.jonas@de.bosch.com> (raw)

From: Ricardo Simoes <ricardo.simoes@pt.bosch.com>

The recipe `volatile-binds` relies on the `mount-copybind` script
to create volatile mount points. In commit [1], the script was modified
to use OverlayFS as the primary mount strategy. If OverlayFS fails, it
falls back to an old-school bind mount.

To meet the requirements of OverlayFS, the script now unconditionally
creates a workdir. However, the newly created directory is left in
place in case the bind mount strategy is used.

Commit [2] introduced support for avoiding the OverlayFS strategy by
setting the `MOUNT_COPYBIND_AVOID_OVERLAYFS` environment variable.
However, the workdir is unconditionally created.

This patch series addresses both problems. Firstly, it only creates
the workdir if the `MOUNT_COPYBIND_AVOID_OVERLAYFS` variable is not
asserted. Secondly, it unconditionally attempts to remove the workdir
in case a bind mount is done.

[1] b4976f3cf8cd028f165100b67867adb862da4d7f
	volatile-binds: use overlayfs if available

[2] a8e7dca69054798b1c9843a0de889cef3e261c4f
	mount-copybind: add MOUNT_COPYBIND_AVOID_OVERLAYFS env var to
	skip OverlayFS

Ricardo Simoes (2):
  volatile-binds: Do not create workdir if OverlayFS is disabled
  volatile-binds: Remove workdir if OverlayFS fails

 meta/recipes-core/volatile-binds/files/mount-copybind | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

-- 
2.25.1



             reply	other threads:[~2024-07-18  6:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-18  6:46 mark.jonas [this message]
2024-07-18  6:46 ` [PATCH 1/2] volatile-binds: Do not create workdir if OverlayFS is disabled mark.jonas
2024-07-18  6:46 ` [PATCH 2/2] volatile-binds: Remove workdir if OverlayFS fails mark.jonas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240718064634.7276-1-mark.jonas@de.bosch.com \
    --to=mark.jonas@de.bosch.com \
    --cc=bluca@debian.org \
    --cc=luca.boccassi@microsoft.com \
    --cc=matt.hoosier@garmin.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=ricardo.simoes@pt.bosch.com \
    --cc=richard.purdie@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox