From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: Qi.Chen@windriver.com
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 0/2] Change the way of handling CONFFILES
Date: Fri, 13 Dec 2013 16:51:51 +0000 [thread overview]
Message-ID: <2024453.Je7eP6C3oy@helios> (raw)
In-Reply-To: <cover.1386903269.git.Qi.Chen@windriver.com>
Hi Qi,
On Friday 13 December 2013 11:09:01 Qi.Chen@windriver.com wrote:
> It's a very common situation in OE/Yocto that the recipe authors/maintainers
> either forget to set the CONFFILES variable or set it wrong.
>
> For example, we don't have CONFFILES set in the shadow recipe. As a result,
> /etc/login.defs from the shadow package is not treated as a config file.
> Another example is the base-files recipe. We set the CONFFILES variable, but
> it's not a complete list. Basically, all files under /etc should be treated
> as config files for this recipe.
>
> Such mistakes are not easy to find, because when we add or upgrade a recipe,
> we usually only test whether it functions well, we don't take into
> consideration the on-target upgrade process.
>
> So we need to improve the situation here.
>
> This patchset consists of two patches. The first one is the main patch which
> changes the way CONFFILES is handled in our project. The second one serves
> as an example how to fix individual recipes.
>
> As almost all files under /etc should be considerred as config files, we
> don't need to modify a lot of recipes after the first patch. Take shadow as
> an example. We don't need to modify that recipe after this change. The ones
> that need to be paid attention to are those that set CONFFILES in their
> recipes. The second patch serves as an exmple how to fix this.
This definitely sounds like a good idea, but do we need to give special
consideration to /etc/init.d/ since files under there aren't really
configuration files?
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
next prev parent reply other threads:[~2013-12-13 16:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-13 3:09 [PATCH 0/2] Change the way of handling CONFFILES Qi.Chen
2013-12-13 3:09 ` [PATCH 1/2] packaging: change the process of CONFFILES handling Qi.Chen
2013-12-13 3:09 ` [PATCH 2/2] base-files: Fix CONFFILES Qi.Chen
2013-12-13 16:51 ` Paul Eggleton [this message]
2013-12-16 2:12 ` [PATCH 0/2] Change the way of handling CONFFILES ChenQi
2013-12-13 17:18 ` Enrico Scholz
2013-12-16 2:20 ` ChenQi
2013-12-16 10:34 ` Burton, Ross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024453.Je7eP6C3oy@helios \
--to=paul.eggleton@linux.intel.com \
--cc=Qi.Chen@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox