From: Pedro Ferreira <pmi183@gmail.com>
To: openembedded-core@lists.openembedded.org
Cc: Pedro Ferreira <Pedro.Silva.Ferreira@criticaltechworks.com>
Subject: [PATCH] buildhistory.bbclass: restore BUILDHISTORY_PRESERVE files
Date: Wed, 15 Jan 2025 15:31:49 +0000 [thread overview]
Message-ID: <20250115153149.1827119-1-pmi183@gmail.com> (raw)
From: Pedro Ferreira <Pedro.Silva.Ferreira@criticaltechworks.com>
On each build using sstate-cache, buildhistory will move
content to a temporary folder named `old`.
When buildhistory looks for the main dir, it wont find it
and ends up creating it.
As a consequence how code is structured wont restore any
preserved file.
Code block moved to ensure if old dir exists, it will
attempt to restore those files marked to preserve.
Signed-off-by: Pedro Silva Ferreira <Pedro.Silva.Ferreira@criticaltechworks.com>
---
meta/classes/buildhistory.bbclass | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/meta/classes/buildhistory.bbclass b/meta/classes/buildhistory.bbclass
index d735dd5fb5..b0f395f05e 100644
--- a/meta/classes/buildhistory.bbclass
+++ b/meta/classes/buildhistory.bbclass
@@ -260,14 +260,6 @@ python buildhistory_emit_pkghistory() {
if not os.path.exists(pkghistdir):
bb.utils.mkdirhier(pkghistdir)
else:
- # We need to make sure that all files kept in
- # buildhistory/old are restored successfully
- # otherwise next block of code wont have files to
- # check and purge
- if d.getVar("BUILDHISTORY_RESET"):
- for pkg in packagelist:
- preservebuildhistoryfiles(pkg, preserve)
-
# Remove files for packages that no longer exist
for item in os.listdir(pkghistdir):
if item not in preserve:
@@ -280,6 +272,13 @@ python buildhistory_emit_pkghistory() {
else:
os.unlink(itempath)
+ if os.path.exists(oldpkghistdir):
+ # We need to make sure that all files in preserve
+ # are restored from buildhistory/old successfully
+ if d.getVar("BUILDHISTORY_RESET"):
+ for pkg in packagelist:
+ preservebuildhistoryfiles(pkg, preserve)
+
rcpinfo = RecipeInfo(pn)
rcpinfo.pe = pe
rcpinfo.pv = pv
--
2.34.1
next reply other threads:[~2025-01-15 15:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-15 15:31 Pedro Ferreira [this message]
2025-01-22 13:42 ` [OE-core] [PATCH] buildhistory.bbclass: restore BUILDHISTORY_PRESERVE files Ross Burton
2025-01-23 14:37 ` Pedro Ferreira
2025-03-06 14:26 ` Pedro Ferreira
2025-03-12 13:40 ` [OE-core] " Ross Burton
2025-06-23 20:48 ` Richard Purdie
2025-06-25 10:26 ` Fabio Berton
2025-06-25 10:46 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250115153149.1827119-1-pmi183@gmail.com \
--to=pmi183@gmail.com \
--cc=Pedro.Silva.Ferreira@criticaltechworks.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox