From: Christos Gavros <gavrosc@yahoo.com>
To: openembedded-core@lists.openembedded.org
Cc: Christos Gavros <gavrosc@yahoo.com>,
Yoann Congal <yoann.congal@smile.fr>
Subject: [PATCH v4] sanity: test for c toolchain
Date: Mon, 20 Jan 2025 20:46:36 +0100 [thread overview]
Message-ID: <20250120194636.22297-1-gavrosc@yahoo.com> (raw)
In-Reply-To: 20250120194636.22297-1-gavrosc.ref@yahoo.com
Users reported issues caused by missing the right libstdc++-version-dev.
A new function 'check_c_toolchain' added in sanity.bbclass to test linking libstdc++
Fixes [YOCTO #15712]
Signed-off-by: Christos Gavros <gavrosc@yahoo.com>
Reviewed-by: Yoann Congal <yoann.congal@smile.fr>
---
v3->v4
* move new function call in 'check_sanity_version_change()'
---
meta/classes-global/sanity.bbclass | 40 ++++++++++++++++++++++++++++++
1 file changed, 40 insertions(+)
diff --git a/meta/classes-global/sanity.bbclass b/meta/classes-global/sanity.bbclass
index 7b8a497d5a..26ce5fbc09 100644
--- a/meta/classes-global/sanity.bbclass
+++ b/meta/classes-global/sanity.bbclass
@@ -602,6 +602,43 @@ def drop_v14_cross_builds(d):
bb.utils.remove(stamp + "*")
bb.utils.remove(workdir, recurse = True)
+def check_c_toolchain(d):
+ """
+ it checks if the c compiling and linking to libstdc++ works properly in the native system
+ """
+ import os
+ import subprocess
+ from tempfile import NamedTemporaryFile
+
+ try:
+ with NamedTemporaryFile(delete=False, suffix=".c") as c_file:
+ c_code = """
+ #include <stdio.h>
+ int main() {
+ printf(\"Hello, World!\\n\");
+ return 0;
+ }
+ """
+ c_file.write(c_code.encode('utf-8'))
+ c_file_name = c_file.name
+
+ build_cc = d.getVar('BUILD_CC').strip()
+ output_binary = c_file_name + ".out"
+ compile_command = [build_cc, c_file_name, '-o', output_binary,'-lstdc++']
+ result = subprocess.run(compile_command, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
+
+ if result.returncode == 0:
+ return None
+ else:
+ return f"C toolchain check failed to link against libstdc++. Please ensure libstdc++ and headers are installed. Error:\n{result.stderr.decode()}"
+ except Exception as e:
+ return f"An unexpected issue occurred during the C toolchain check: {str(e)}"
+ finally:
+ if c_file_name and os.path.exists(c_file_name):
+ os.remove(c_file_name)
+ if output_binary and os.path.exists(output_binary):
+ os.remove(output_binary)
+
def sanity_handle_abichanges(status, d):
#
# Check the 'ABI' of TMPDIR
@@ -770,6 +807,9 @@ def check_sanity_version_change(status, d):
# macOS with default HFS+ file system)
status.addresult(check_case_sensitive(tmpdir, "TMPDIR"))
+ # Check if linking with lstdc++ is failing
+ status.addresult(check_c_toolchain(d))
+
def sanity_check_locale(d):
"""
Currently bitbake switches locale to en_US.UTF-8 so check that this locale actually exists.
--
2.34.1
next parent reply other threads:[~2025-01-20 19:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250120194636.22297-1-gavrosc.ref@yahoo.com>
2025-01-20 19:46 ` Christos Gavros [this message]
2025-01-21 15:29 ` [OE-core] [PATCH v4] sanity: test for c toolchain Ross Burton
2025-01-21 15:41 ` Christos Gavros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250120194636.22297-1-gavrosc@yahoo.com \
--to=gavrosc@yahoo.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=yoann.congal@smile.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox