From: Akash Hadke <akash.hadke27@gmail.com>
To: openembedded-core@lists.openembedded.org
Subject: [poky][scarthgap][PATCH 23/23] bitbake: fetch2/git: Add multiple revision support
Date: Fri, 8 Aug 2025 14:19:31 +0530 [thread overview]
Message-ID: <20250808084931.2156763-23-akash.hadke27@gmail.com> (raw)
In-Reply-To: <20250808084931.2156763-1-akash.hadke27@gmail.com>
In scarthgap single SRC_URI can still have multiple revisions
update the code in order to iterate over these revisions and
do the fetch.
Signed-off-by: Akash Hadke <akash.hadke27@gmail.com>
---
bitbake/lib/bb/fetch2/git.py | 20 +++++++++++---------
1 file changed, 11 insertions(+), 9 deletions(-)
diff --git a/bitbake/lib/bb/fetch2/git.py b/bitbake/lib/bb/fetch2/git.py
index 390d9ddafc..88fa119e1d 100644
--- a/bitbake/lib/bb/fetch2/git.py
+++ b/bitbake/lib/bb/fetch2/git.py
@@ -513,12 +513,13 @@ class Git(FetchMethod):
raise bb.fetch2.FetchError("Unable to find revision %s even from upstream" % missing_rev)
if self.lfs_need_update(ud, d):
- self.lfs_fetch(ud, d, ud.clonedir, ud.revision)
+ for name in ud.names:
+ self.lfs_fetch(ud, d, name, ud.clonedir, ud.revisions[name])
- def lfs_fetch(self, ud, d, clonedir, revision, fetchall=False, progresshandler=None):
+ def lfs_fetch(self, ud, d, name, clonedir, revision, fetchall=False, progresshandler=None):
"""Helper method for fetching Git LFS data"""
try:
- if self._need_lfs(ud) and self._contains_lfs(ud, d, clonedir) and len(revision):
+ if self._need_lfs(ud) and self._contains_lfs(ud, d, name, clonedir) and len(revision):
self._ensure_git_lfs(d, ud)
# Using worktree with the revision because .lfsconfig may exists
@@ -649,7 +650,7 @@ class Git(FetchMethod):
runfetchcmd(fetch_cmd, d, workdir=dest)
runfetchcmd("%s update-ref %s %s" % (ud.basecmd, ref, revision), d, workdir=dest)
# Fetch Git LFS data
- self.lfs_fetch(ud, d, dest, ud.revisions[ud.names[0]])
+ self.lfs_fetch(ud, d, name, dest, ud.revisions[ud.names[0]])
# Apply extra ref wildcards
all_refs_remote = runfetchcmd("%s ls-remote origin 'refs/*'" % ud.basecmd, \
@@ -738,7 +739,7 @@ class Git(FetchMethod):
repourl = self._get_repo_url(ud)
runfetchcmd("%s remote set-url origin %s" % (ud.basecmd, shlex.quote(repourl)), d, workdir=destdir)
- if self._contains_lfs(ud, d, destdir):
+ if any(self._contains_lfs(ud, d, name, destdir) for name in ud.names):
if not need_lfs:
bb.note("Repository %s has LFS content but it is not being fetched" % (repourl))
else:
@@ -806,8 +807,9 @@ class Git(FetchMethod):
Verifies whether the LFS objects for requested revisions have already been downloaded
"""
# Bail out early if this repository doesn't use LFS
- if not self._contains_lfs(ud, d, wd):
- return True
+ for name in ud.names:
+ if not self._contains_lfs(ud, d, name, wd):
+ return True
self._ensure_git_lfs(d, ud)
@@ -835,12 +837,12 @@ class Git(FetchMethod):
def _need_lfs(self, ud):
return ud.parm.get("lfs", "1") == "1"
- def _contains_lfs(self, ud, d, wd):
+ def _contains_lfs(self, ud, d, name, wd):
"""
Check if the repository has 'lfs' (large file) content
"""
cmd = "%s grep lfs %s:.gitattributes | wc -l" % (
- ud.basecmd, ud.revision)
+ ud.basecmd, ud.revisions[name])
try:
output = runfetchcmd(cmd, d, quiet=True, workdir=wd)
--
2.25.1
next prev parent reply other threads:[~2025-08-08 8:50 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-08 8:49 [poky][scarthgap][PATCH 01/23] bitbake: fetch2/git: Use git shallow fetch to implement clone_shallow_local() Akash Hadke
2025-08-08 8:49 ` [poky][scarthgap][PATCH 02/23] bitbake: bitbake: tests/fetch: Update GitShallowTest for clone_shallow_local() Akash Hadke
2025-08-08 9:10 ` Patchtest results for " patchtest
2025-08-08 8:49 ` [poky][scarthgap][PATCH 03/23] bitbake: fetch2/git: Enforce default remote name to "origin" Akash Hadke
2025-08-08 9:10 ` Patchtest results for " patchtest
2025-08-08 8:49 ` [poky][scarthgap][PATCH 04/23] bitbake: gitsm: Add clean function Akash Hadke
2025-08-08 9:10 ` Patchtest results for " patchtest
2025-08-08 8:49 ` [poky][scarthgap][PATCH 05/23] bitbake: git: Clean shallow mirror tarball Akash Hadke
2025-08-08 9:10 ` Patchtest results for " patchtest
2025-08-08 8:49 ` [poky][scarthgap][PATCH 06/23] bitbake: git: Clean broken symlink Akash Hadke
2025-08-08 9:10 ` Patchtest results for " patchtest
2025-08-08 8:49 ` [poky][scarthgap][PATCH 07/23] bitbake: lib: Remove double imports Akash Hadke
2025-08-08 9:10 ` Patchtest results for " patchtest
2025-08-08 8:49 ` [poky][scarthgap][PATCH 08/23] bitbake: fetch2/git: Add support for fast initial shallow fetch Akash Hadke
2025-08-08 9:10 ` Patchtest results for " patchtest
2025-08-08 8:49 ` [poky][scarthgap][PATCH 09/23] bitbake: fetch2/gitsm: Unpack even when `ud.clonedir` is not available Akash Hadke
2025-08-08 9:10 ` Patchtest results for " patchtest
2025-08-08 8:49 ` [poky][scarthgap][PATCH 10/23] bitbake: tests/fetch: Adapt test cases for fast shallow fetches Akash Hadke
2025-08-08 9:10 ` Patchtest results for " patchtest
2025-08-08 8:49 ` [poky][scarthgap][PATCH 11/23] bitbake: fetch2/git: Restore escape quoting for the git url when used Akash Hadke
2025-08-08 9:10 ` Patchtest results for " patchtest
2025-08-08 8:49 ` [poky][scarthgap][PATCH 12/23] bitbake: fetch/git: always fetch lfs when creating shallow tarball Akash Hadke
2025-08-08 9:10 ` Patchtest results for " patchtest
2025-08-08 8:49 ` [poky][scarthgap][PATCH 13/23] bitbake: tests/fetch: Move commonly used imports to top Akash Hadke
2025-08-08 9:10 ` Patchtest results for " patchtest
2025-08-08 8:49 ` [poky][scarthgap][PATCH 14/23] bitbake: fetch2: Check for git-lfs existence before using it Akash Hadke
2025-08-08 9:10 ` Patchtest results for " patchtest
2025-08-08 8:49 ` [poky][scarthgap][PATCH 15/23] bitbake: fetch2: Simplify git LFS detection Akash Hadke
2025-08-08 9:10 ` Patchtest results for " patchtest
2025-08-08 8:49 ` [poky][scarthgap][PATCH 16/23] bitbake: fetch2: Use git-lfs fetch to download objects Akash Hadke
2025-08-08 9:10 ` Patchtest results for " patchtest
2025-08-08 8:49 ` [poky][scarthgap][PATCH 17/23] bitbake: fetch2: Fix incorrect lfs parametrization for submodules Akash Hadke
2025-08-08 9:10 ` Patchtest results for " patchtest
2025-08-08 8:49 ` [poky][scarthgap][PATCH 18/23] bitbake: fetch2: Fix LFS object checkout in submodules Akash Hadke
2025-08-08 9:10 ` Patchtest results for " patchtest
2025-08-08 8:49 ` [poky][scarthgap][PATCH 19/23] bitbake: tests/fetch: Test gitsm with LFS Akash Hadke
2025-08-08 9:10 ` Patchtest results for " patchtest
2025-08-08 8:49 ` [poky][scarthgap][PATCH 20/23] bitbake: fetch2/git: fix shallow clone for tag containing slash Akash Hadke
2025-08-08 9:10 ` Patchtest results for " patchtest
2025-08-08 8:49 ` [poky][scarthgap][PATCH 21/23] bitbake: fetch2: Move the `ensure_symlink()` function into the `FetchMethod` class Akash Hadke
2025-08-08 9:10 ` Patchtest results for " patchtest
2025-08-08 8:49 ` [poky][scarthgap][PATCH 22/23] bitbake: fetch2: Ensure a valid symlink in `PREMIRRORS` case when using shallow cloning Akash Hadke
2025-08-08 9:10 ` Patchtest results for " patchtest
2025-08-08 8:49 ` Akash Hadke [this message]
2025-08-08 9:10 ` Patchtest results for [poky][scarthgap][PATCH 23/23] bitbake: fetch2/git: Add multiple revision support patchtest
2025-08-11 8:23 ` [OE-core] " Alexander Kanavin
[not found] ` <10458.1760096658331781386@lists.openembedded.org>
2025-10-10 12:41 ` Richard Purdie
2025-08-08 9:10 ` Patchtest results for [poky][scarthgap][PATCH 01/23] bitbake: fetch2/git: Use git shallow fetch to implement clone_shallow_local() patchtest
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250808084931.2156763-23-akash.hadke27@gmail.com \
--to=akash.hadke27@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox